Groups > linux.kernel > #1220005

Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	maitysanchayan@gmail.com
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
Date	Mon, 07 Sep 2015 11:00:02 +0200
Message-ID	<q60ro-F2-9@gated-at.bofh.it> (permalink)
References	<pUvTZ-5yr-41@gated-at.bofh.it> <q5zUe-538-3@gated-at.bofh.it>
X-Original-To	Shawn Guo <shawnguo@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=l0CdNdnIbHoUOCMGrVGMczXUZ7OoTUpfBmzV9Oabe8o=; b=VCl4q0rP31IOl2rKpmrS87fl59okOYLsjxLBCo1rT/cSBkCtE9ZQGmkqZYBanSQWv/ JXa3RpEs0Fi06Csl56cGeQYm1lgkgM5ANzvd1gvxr8gN7Zyn9g4FGEY0mz5ZKO7nRU3h tdl1bJUGmpY+WSr8xOjvu5BQ+sIRH2LYH3npiE5h9OpioZR5CYMo5d7ZGY4jx0YelYr8 wi7oYBJhuGpV+b97aNX3NyXam6BT7WQyk5PQ1iY0DumqeP09ztiKGqhXjDxfjkTfIkst 1Eqvyio71EdICyFJr8XNIKYJT+qwO0xmghtLTqrsngijm415h+PAx898iCQQVmZuJeRa tVpw==
X-Received	by 10.68.104.98 with SMTP id gd2mr43915751pbb.130.1441615961311; Mon, 07 Sep 2015 01:52:41 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	stefan@agner.ch, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 7 Sep 2015 14:19:11 +0530
X-Original-Message-ID	<20150907084911.GA6877@Sanchayan-Arch.toradex.int>
X-Original-References	<b639ca620369d196491a4af8739b87d580e71bf6.1438876380.git.maitysanchayan@gmail.com> <20150906043232.GD30746@tiger>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220005

Show key headers only | View raw

Hi Shawn,

On 15-09-06 12:32:32, Shawn Guo wrote:
> On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > Add iio_hwmon node to expose the temperature channel on Vybrid
> > as hardware monitor device using the iio_hwmon driver.
> > 
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> >  arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > index 39173bb..0993d66 100644
> > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > @@ -597,5 +597,10 @@
> >  				status = "disabled";
> >  			};
> >  		};
> > +
> > +		iio_hwmon {
> 
> Hyphen rather than underscore should be used in node name.

As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.

http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246

So should this be changed?

Thanks.

- Sanchayan.

> 
> Shawn
> 
> > +			compatible = "iio-hwmon";
> > +			io-channels = <&adc0 16>;
> > +		};
> >  	};
> >  };
> > -- 
> > 2.5.0
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH]  ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature  channel Shawn Guo <shawnguo@kernel.org> - 2015-09-06 06:40 +0200
  Re: [PATCH]  ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature  channel maitysanchayan@gmail.com - 2015-09-07 11:00 +0200
    Re: [PATCH]  ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature  channel Shawn Guo <shawnguo@kernel.org> - 2015-09-17 03:10 +0200

csiph-web