Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1219702 > unrolled thread
| Started by | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| First post | 2015-09-06 06:40 +0200 |
| Last post | 2015-09-17 03:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Shawn Guo <shawnguo@kernel.org> - 2015-09-06 06:40 +0200
Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel maitysanchayan@gmail.com - 2015-09-07 11:00 +0200
Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Shawn Guo <shawnguo@kernel.org> - 2015-09-17 03:10 +0200
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2015-09-06 06:40 +0200 |
| Subject | Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel |
| Message-ID | <q5zUe-538-3@gated-at.bofh.it> |
On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> Add iio_hwmon node to expose the temperature channel on Vybrid
> as hardware monitor device using the iio_hwmon driver.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 39173bb..0993d66 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -597,5 +597,10 @@
> status = "disabled";
> };
> };
> +
> + iio_hwmon {
Hyphen rather than underscore should be used in node name.
Shawn
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 16>;
> + };
> };
> };
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | maitysanchayan@gmail.com |
|---|---|
| Date | 2015-09-07 11:00 +0200 |
| Message-ID | <q60ro-F2-9@gated-at.bofh.it> |
| In reply to | #1219702 |
Hi Shawn,
On 15-09-06 12:32:32, Shawn Guo wrote:
> On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > Add iio_hwmon node to expose the temperature channel on Vybrid
> > as hardware monitor device using the iio_hwmon driver.
> >
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > index 39173bb..0993d66 100644
> > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > @@ -597,5 +597,10 @@
> > status = "disabled";
> > };
> > };
> > +
> > + iio_hwmon {
>
> Hyphen rather than underscore should be used in node name.
As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246
So should this be changed?
Thanks.
- Sanchayan.
>
> Shawn
>
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 16>;
> > + };
> > };
> > };
> > --
> > 2.5.0
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2015-09-17 03:10 +0200 |
| Message-ID | <q9vS2-4DE-17@gated-at.bofh.it> |
| In reply to | #1220005 |
On Mon, Sep 07, 2015 at 02:19:11PM +0530, maitysanchayan@gmail.com wrote:
> Hi Shawn,
>
> On 15-09-06 12:32:32, Shawn Guo wrote:
> > On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > > Add iio_hwmon node to expose the temperature channel on Vybrid
> > > as hardware monitor device using the iio_hwmon driver.
> > >
> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > > ---
> > > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > > index 39173bb..0993d66 100644
> > > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > > @@ -597,5 +597,10 @@
> > > status = "disabled";
> > > };
> > > };
> > > +
> > > + iio_hwmon {
> >
> > Hyphen rather than underscore should be used in node name.
>
> As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.
>
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
> http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
> http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246
Oh, sorry, all these should be caught earlier.
>
> So should this be changed?
Yeah, that would be nice, if the change doesn't break anything.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web