Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1219784

Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver

From "Wu, Songjun" <songjun.wu@atmel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date 2015-09-06 11:50 +0200
Message-ID <q5EKf-3sJ-13@gated-at.bofh.it> (permalink)
References <q3MCd-5Sy-1@gated-at.bofh.it> <q3MCf-5Sy-7@gated-at.bofh.it> <q4Bv3-36H-17@gated-at.bofh.it>
Organization ATMEL

Show all headers | View raw



On 9/3/2015 19:43, Mark Brown wrote:
> On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote:
>
>> +classd: classd@fc048000 {
>> +		compatible = "atmel,sama5d2-classd";
>> +		reg = <0xfc048000 0x100>;
>> +		interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>;
>> +		dmas = <&dma0
>> +			(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1)
>> +			| AT91_XDMAC_DT_PERID(47))>;
>> +		dma-names = "tx";
>> +		clocks = <&classd_clk>, <&classd_gclk>, <&audio_pll_pmc>;
>> +		clock-names = "pclk", "gclk", "aclk";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_classd_default>;
>> +		atmel,pwm-type = "diff";
>> +		atmel,non-overlap-time = <10>;
>> +};
>
>> +Example:
>> +sound {
>> +		compatible = "atmel,asoc-classd";
>> +
>> +		atmel,model = "classd @ SAMA5D2-Xplained";
>> +		atmel,audio-platform = <&classd>;
>> +		atmel,audio-cpu-dai-name = "fc048000.classd";
>> +		atmel,audio-codec = <&classd>;
>> +};
>
> Why is this a separate DT node?  It seems that this IP is entirely self
> contained so I'm not clear why we need a separate node for the card, the
> card is usually a separate node because it ties together multiple
> different devices in the system but that's not the case here.
>
The classD can finish the audio function without other devices.
But I want to reuse the code in ASoC, leave many things(like creating 
PCM, DMA operations) to ASoC, then the driver can only focus on how to 
configure classD.
The classD IP is divided to tree parts logically, platform, CPU dai,
and codec, and these parts are registered to ASoC.

This separate DT node is needed in ASoC, ties these tree parts in ClassD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu <songjun.wu@atmel.com> - 2015-09-01 07:50 +0200
  [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Songjun Wu <songjun.wu@atmel.com> - 2015-09-01 07:50 +0200
    Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver Mark Brown <broonie@kernel.org> - 2015-09-03 14:10 +0200
      Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-06 11:50 +0200
        Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver Mark Brown <broonie@kernel.org> - 2015-09-07 18:30 +0200
          Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-08 11:40 +0200
            Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver Mark Brown <broonie@kernel.org> - 2015-09-08 14:30 +0200
              Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-09 05:20 +0200
              Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-15 05:20 +0200
                Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver Mark Brown <broonie@kernel.org> - 2015-09-16 21:50 +0200
                Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio  amplifier driver "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-17 05:10 +0200
  [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Songjun Wu <songjun.wu@atmel.com> - 2015-09-01 07:50 +0200
    Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-03 13:40 +0200
      Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-06 11:50 +0200
        Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-07 18:30 +0200
          Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-08 11:40 +0200
            Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-08 14:30 +0200
              Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-09 05:20 +0200
                Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-09 12:00 +0200
                Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-10 04:40 +0200
                Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code Mark Brown <broonie@kernel.org> - 2015-09-11 12:40 +0200
                Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier  code "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-14 08:40 +0200

csiph-web