Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219089

Re: [PATCH] cpupower tools: Fix error when running cpupower monitor

Show all headers | View raw

On Thursday, September 03, 2015 11:51:22 AM Shreyas B Prabhu wrote:
> 
> On 08/25/2015 05:29 PM, Shreyas B Prabhu wrote:
> > 
> > 
> > On 08/17/2015 01:22 PM, Shreyas B Prabhu wrote:
> >>
> >>
> >> On 08/10/2015 05:58 PM, Thomas Renninger wrote:
> >>> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
> >>>> get_cpu_topology() tries to get topology info from all cpus by reading
> >>>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
> >>>> have topology dir, this function fails and returns -1. This causes
> >>>> functions relying on get_cpu_topology() to fail. For example-
> >>>>
> >>>> $ cpupower monitor
> >>>> Cannot read number of available processors
> >>>>
> >>>> Fix this by skipping fetching topology info for offline cpus.
> >>>
> >>> Looks fine.
> >>>
> >>> Thanks!
> >>>
> >>> Acked-by: Thomas Renninger <trenn@suse.de>
> >>>
> >>
> >> Thanks Thomas!
> >> Rafael, can you please pick this patch?
> >>
> >>
> > 
> > 
> > Hi Rafael,
> > 
> > If this patch looks good can you please pick this up?
> > 
> > 
> > Thanks,
> > Shreyas
> > 
> 
> Hi Rafael,
> 
> If this patch looks good can you please pick this up?

I picked it up last week, sorry for being silent about that.

It should be in the Linus' tree already.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpupower tools: Fix error when running cpupower monitor Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2015-08-25 14:10 +0200
  Re: [PATCH] cpupower tools: Fix error when running cpupower monitor Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2015-09-03 08:30 +0200
    Re: [PATCH] cpupower tools: Fix error when running cpupower monitor "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-04 16:30 +0200
      Re: [PATCH] cpupower tools: Fix error when running cpupower monitor Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2015-09-04 16:40 +0200

csiph-web