Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219088

Re: [PATCH] cpufreq: pass policy to ->get() driver callback

Show all headers | View raw

On Thursday, September 03, 2015 10:15:45 AM Viresh Kumar wrote:
> On 31-07-15, 16:14, Viresh Kumar wrote:
> > CPUFreq drivers today support ->get(cpu) callback, which returns current
> > clock rate of the CPU. The problem with ->get() is that it takes cpu
> > number as parameter and this unnecessarily makes things complex.
> > 
> > Firstly the core gets the cpu number by doing operation 'policy->cpu' on
> > the policy and then many drivers need to get the policy back and so do
> > cpufreq_cpu_get(cpu) on the cpu passed as argument to ->get().
> > 
> > It would be better if we pass them 'policy' directly and drivers can use
> > policy->cpu if that's all they need.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Is this getting moved to 4.4?

I'm really unsure about this change at all.

I have a concern that it may not go in the right direction.  I'll say more about
that later today.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpufreq: pass policy to ->get() driver callback Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-03 06:50 +0200
  Re: [PATCH] cpufreq: pass policy to ->get() driver callback "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-04 16:30 +0200

csiph-web