Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq
Date	2015-09-02 10:20 +0200
Message-ID	<q4bqV-7Rc-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <pZwmm-3AQ-17@gated-at.bofh.it> <q3zbY-3fy-21@gated-at.bofh.it> <q3HCy-722-3@gated-at.bofh.it> <q3Vma-1Gq-15@gated-at.bofh.it> <q467U-ax-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 02, 2015 at 11:33:15AM +0900, Byungchul Park wrote:
> +++ b/kernel/sched/fair.c
> @@ -7920,14 +7920,14 @@ prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio)
>  
>  static inline bool vruntime_normalized(struct task_struct *p)
>  {
>  	struct sched_entity *se = &p->se;
>  
>  	/*
> +	 * In both TASK_ON_RQ_QUEUED case and TASK_ON_RQ_MIGRATING case,
> +	 * the dequeue_entity(.flags=0) will already have normalized the
> +	 * vruntime.
>  	 */
> +	if (p->on_rq)
>  		return true;
>  

You're right. And yes this is nicer. Thanks!

I've folded it into your 5/5 patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 2/5] sched: make task_move_group_fair adjust cfs_rq's load in case of queued byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq byungchul.park@lge.com - 2015-08-20 13:30 +0200
    Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-08-20 13:40 +0200
      Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:30 +0200
        Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:40 +0200
        Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-01 02:30 +0200
          Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-01 05:00 +0200
          Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-09-01 17:10 +0200
            Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-02 04:40 +0200
              Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-09-02 10:20 +0200
                Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Ingo Molnar <mingo@kernel.org> - 2015-09-02 10:40 +0200
  [PATCH v4 4/5] sched: sync a se with its cfs_rq when switching sched class to fair class byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 1/5] sched: add two functions adjusting cfs_rq's load when att(det)aching a se byungchul.park@lge.com - 2015-08-20 13:30 +0200
  Re: [PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it Byungchul Park <byungchul.park@lge.com> - 2015-08-22 09:50 +0200
  Re: [PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it Byungchul Park <byungchul.park@lge.com> - 2015-08-26 02:00 +0200

csiph-web