Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213445

Re: [PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it

Show all headers | View raw

On Thu, Aug 20, 2015 at 08:21:55PM +0900, byungchul.park@lge.com wrote:
> From: Byungchul Park <byungchul.park@lge.com>
> 

i am sorry for making a push ; but is there anything for me to improve
for this patch set?

and i forgot to add scheduler related persons to CC and do it.

> there are 3 problems when att(det)aching a se to(from) its cfs_rq.
> 
> problem 1. se's average load is not accounted with new cfs_rq in queued case,
> when a task changes its cgroup.
> 
> problem 2. cfs_rq->avg.load_avg becomes larger and larger whenever changing
> cgroup to another. we have to sync se's average load with prev cfs_rq.
> 
> problem 3. current code does not sync it with its cfs_rq when switching
> sched class to fair class. if we can always assume that a se has been
> detached from fair class for a long time enough for its average load to
> become useless, at the time attaching it to its fair class cfs_rq, then
> current code is acceptable. but the assumption is not always true.
> 
> patch 1/5, does code refactoring for further patches.
> patch 2/5, solves the problem 1.
> patch 3/5, solves the problem 2.
> patch 4/5, solves the problem 3.
> patch 5/5, does code refactoring for better readability.
> 
> change from v3 to v4
> * clean up code as Peter suggests
> * use upper case letter in comment properly
> 
> change from v2 to v3 (logic is same as v2)
> * fix up my poor english in commit message and comment
> * break down big patches into more patches for being reviewed easily
> * supplement cover letter messages
> 
> change from v1 to v2
> * introduce two functions for adjusting vruntime and load when attaching
>   and detaching.
> * call the introduced functions instead of switched_from(to)_fair() directly
>   in task_move_group_fair().
> * add decaying logic for a se which has detached from a cfs_rq.
> 
> thanks,
> byungchul
> 
> Byungchul Park (5):
>   sched: add two functions adjusting cfs_rq's load when att(det)aching
>     a se
>   sched: make task_move_group_fair adjust cfs_rq's load in case of
>     queued
>   sched: sync a se with prev cfs_rq when changing cgroup
>   sched: sync a se with its cfs_rq when switching sched class to fair
>     class
>   sched: add two functions for att(det)aching a task to(from) a cfs_rq
> 
>  kernel/sched/fair.c |  222 ++++++++++++++++++++++++++-------------------------
>  1 file changed, 113 insertions(+), 109 deletions(-)
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 2/5] sched: make task_move_group_fair adjust cfs_rq's load in case of queued byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq byungchul.park@lge.com - 2015-08-20 13:30 +0200
    Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-08-20 13:40 +0200
      Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:30 +0200
        Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:40 +0200
        Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-01 02:30 +0200
          Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-01 05:00 +0200
          Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-09-01 17:10 +0200
            Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Byungchul Park <byungchul.park@lge.com> - 2015-09-02 04:40 +0200
              Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Peter Zijlstra <peterz@infradead.org> - 2015-09-02 10:20 +0200
                Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a  task to(from) a cfs_rq Ingo Molnar <mingo@kernel.org> - 2015-09-02 10:40 +0200
  [PATCH v4 4/5] sched: sync a se with its cfs_rq when switching sched class to fair class byungchul.park@lge.com - 2015-08-20 13:30 +0200
  [PATCH v4 1/5] sched: add two functions adjusting cfs_rq's load when att(det)aching a se byungchul.park@lge.com - 2015-08-20 13:30 +0200
  Re: [PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it Byungchul Park <byungchul.park@lge.com> - 2015-08-22 09:50 +0200
  Re: [PATCH v4 0/5] sync a se with its cfs_rq when att(det)aching it Byungchul Park <byungchul.park@lge.com> - 2015-08-26 02:00 +0200

csiph-web