Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
Date	Fri, 04 Sep 2015 08:50:02 +0200
Message-ID	<q4SYW-2Is-15@gated-at.bofh.it> (permalink)
References	<q4Hh9-2W4-41@gated-at.bofh.it> <q4MAb-1Sc-11@gated-at.bofh.it> <q4N3b-2F2-1@gated-at.bofh.it> <q4SFA-2lT-3@gated-at.bofh.it>
X-Original-To	Anand Moon <linux.amoon@gmail.com>, Javier Martinez Canillas <javier@osg.samsung.com>
X-Auditid	cbfec7f4-f79c56d0000012ee-6b-55e93ecd67ed
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xy7pn7V6GGmz5LmTRvKnY4s3bNUwW r18YWvQ/fs1s8ebhZkaLTY+vsVpc3jWHzWLG+X1MFus23mK3uH2Z12L68besDtweLc09bB5/ n19n8dg56y67x6ZVnWwem5fUe2zpB/L6tqxi9Nh8utrj8ya5AM4oLpuU1JzMstQifbsEroxn /SeYC27xV0z4O5GpgfE8TxcjJ4eEgInE/j+P2SFsMYkL99azdTFycQgJLGWU6Nr6Hsr5wijx 5+4aVpAqYQEficOfLjCD2CIC0RJ3tqyAKjrLKHF962lGEIdZ4DWTxJ6e3WBz2QSMJTYvX8IG YvMKaEhsv9gNZrMIqEpcf9IDZosKREicOvsWqkZQ4sfkeywgNqdAsMSE6Y+A4hxAQ9UlpkzJ BQkzC8hLbF7zlnkCo8AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyMk Wr7sYFx8zOoQowAHoxIP74kfL0KFWBPLiitzDzFKcDArifDu/QYU4k1JrKxKLcqPLyrNSS0+ xCjNwaIkzjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA+NaucDg57te9EWsbp9s6ZAqx8yRp9b3 b9HBE/k/rtxY/o5V8oPMLVF3Kekb8U83zrrI/XKncrmZlNSUOxoLRCVmrVd9wmb3gmkzY92O iO0crziWStmLvfuecODpsycZCf0fF5bOdo5O/3Xg00zXQIPXyUY7qx7t9X8rttfnpTr3tum8 ztKvN8spsRRnJBpqMRcVJwIAL+xe3ZICAAA=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	Russell King <linux@arm.linux.org.uk>, Kukjin Kim <kgene@kernel.org>, Andreas Faerber <afaerber@suse.de>, Lukasz Majewski <l.majewski@samsung.com>, Sjoerd Simons <sjoerd.simons@collabora.co.uk>, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Linux Kernel <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 04 Sep 2015 15:48:46 +0900
X-Original-Message-ID	<55E93ECE.60006@samsung.com>
X-Original-References	<1441303910-3266-1-git-send-email-linux.amoon@gmail.com> <55E8DDDD.80106@samsung.com> <55E8E534.1040204@osg.samsung.com> <CANAwSgQOijKEyhvM=DU4nRdGK6v5cxJUZ54pnnG2YqjeT9pBxA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1218688

Show key headers only | View raw

On 04.09.2015 15:20, Anand Moon wrote:
> Hi All,
> 
> On 4 September 2015 at 05:56, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
>> Hello Krzysztof,
>>
>> On 09/04/2015 01:55 AM, Krzysztof Kozlowski wrote:
>>> On 04.09.2015 03:11, Anand Moon wrote:
>>>> Earlier design of the LED for Odroid XU3 was using gpio-leds
>>>> Now It was change to using both pwm-leds and gpio-leds.
>>>
>>> It is still not a reason for this change. gpio-leds were not enabled
>>> before. This could be a valid reason of adding LEDS_PWM to existing
>>> config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on
>>> the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?
>>>
>>
>> Agreed, also the commit message doesn't explain why the heartbeat
>> LED trigger is enabled as I mentioned in the previous version.
>>
>>> Actually I gave up on this and I wanted to change the commit message on
>>> myself when applying. But discussion was brought up again so... clearly
>>> we have different understanding of the meaning of "WHY". :)
>>>
>>> Best regards,
>>> Krzysztof
>>>
> 
> Just of the records. I you agree with following commit message I will
> resend the patch.
> ------------------------------------------------------
> Exynos boards support GPIO and PWM based LEDs
> 
> Odroid boards support led activity to indicate the various status
> Red led - power: hooked up to 5V power
> Blue led - alive Solid light : u-boot is running
>                flashing : Kernel is running (heart beat)
> -------------------------------------------------------
> If you want to add some thing more please suggest me.
> 
> Earlier I was just frustrated.

That commit message looks better. Anyway I applied the patch with
changed message. You can find it here:
https://github.com/krzk/linux/commit/8b14e57ae423b676873e542944ed8714be211ded

although it is not pushed to the for-next branch because we are at merge
window.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-03 20:20 +0200
  Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-04 02:00 +0200
    Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-04 02:30 +0200
      Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 05:00 +0200
      Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 08:30 +0200
        Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-04 08:50 +0200
          Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 09:00 +0200

csiph-web