Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1218684

Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

Show all headers | View raw

Hi All,

On 4 September 2015 at 05:56, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> Hello Krzysztof,
>
> On 09/04/2015 01:55 AM, Krzysztof Kozlowski wrote:
>> On 04.09.2015 03:11, Anand Moon wrote:
>>> Earlier design of the LED for Odroid XU3 was using gpio-leds
>>> Now It was change to using both pwm-leds and gpio-leds.
>>
>> It is still not a reason for this change. gpio-leds were not enabled
>> before. This could be a valid reason of adding LEDS_PWM to existing
>> config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on
>> the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?
>>
>
> Agreed, also the commit message doesn't explain why the heartbeat
> LED trigger is enabled as I mentioned in the previous version.
>
>> Actually I gave up on this and I wanted to change the commit message on
>> myself when applying. But discussion was brought up again so... clearly
>> we have different understanding of the meaning of "WHY". :)
>>
>> Best regards,
>> Krzysztof
>>

Just of the records. I you agree with following commit message I will
resend the patch.
------------------------------------------------------
Exynos boards support GPIO and PWM based LEDs

Odroid boards support led activity to indicate the various status
Red led - power: hooked up to 5V power
Blue led - alive Solid light : u-boot is running
               flashing : Kernel is running (heart beat)
-------------------------------------------------------
If you want to add some thing more please suggest me.

Earlier I was just frustrated.

-Anand Moon

> Best regards,
> --
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-03 20:20 +0200
  Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-04 02:00 +0200
    Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-04 02:30 +0200
      Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 05:00 +0200
      Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 08:30 +0200
        Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-04 08:50 +0200
          Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon <linux.amoon@gmail.com> - 2015-09-04 09:00 +0200

csiph-web