Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1217330

Re: [PATCH] perf, tools, stat: Quieten failed to read counter message

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf, tools, stat: Quieten failed to read counter message
Date 2015-09-02 08:10 +0200
Message-ID <q49p8-501-3@gated-at.bofh.it> (permalink)
References <q42H0-3xO-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Since 3b3eb0445 running perf stat on a system without
> backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> common, make the message a debug message only. We know
> anyways that the counter wasn't read by the normal <unsupported>
> output.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/builtin-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d46dbb1..a96fb5c 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
>  
>  	evlist__for_each(evsel_list, counter) {
>  		if (read_counter(counter))
> -			pr_warning("failed to read counter %s\n", counter->name);
> +			pr_debug("failed to read counter %s\n", counter->name);
>  
>  		if (perf_stat_process_counter(&stat_config, counter))
>  			pr_warning("failed to process counter %s\n", counter->name);
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf, tools, stat: Quieten failed to read counter message Andi Kleen <andi@firstfloor.org> - 2015-09-02 01:00 +0200
  Re: [PATCH] perf, tools, stat: Quieten failed to read counter message Jiri Olsa <jolsa@redhat.com> - 2015-09-02 08:10 +0200
    Re: [PATCH] perf, tools, stat: Quieten failed to read counter message Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-02 15:00 +0200

csiph-web