Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1217115
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Miller <davem@davemloft.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() |
| Date | Wed, 02 Sep 2015 00:10:01 +0200 |
| Message-ID | <q41UB-2Da-11@gated-at.bofh.it> (permalink) |
| References | <q3TX5-7YE-13@gated-at.bofh.it> |
| X-Original-To | msalter@redhat.com |
| X-Mailer | Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) |
| MIME-Version | 1.0 |
| Content-Type | Text/Plain; charset=us-ascii |
| Content-Transfer-Encoding | 7bit |
| X-Greylist | Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Sep 2015 15:03:08 -0700 (PDT) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 31 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | ddaney.cavm@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, buytenh@wantstofly.org, grant.likely@secretlab.ca |
| X-Original-Date | Tue, 01 Sep 2015 15:03:04 -0700 (PDT) |
| X-Original-Message-ID | <20150901.150304.562643685874217745.davem@davemloft.net> |
| X-Original-References | <1441114565-2340-1-git-send-email-msalter@redhat.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1217115 |
Show key headers only | View raw
From: Mark Salter <msalter@redhat.com>
Date: Tue, 1 Sep 2015 09:36:05 -0400
> commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> the bus' parent.") uncovered a problem in mdiobus_unregister() which
> leads to this warning when I reboot an APM Mustang (arm64) platform:
...
> The problem is that mdiobus_unregister() deletes the bus device before
> unregistering the phy devices on the bus. This wasn't a problem before
> because the phys were not children of the bus:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0
>
> But now that they are:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03
>
> when mdiobus_unregister deletes the bus device, the phy subdirs are
> removed from sysfs also. So when the phys are unregistered afterward,
> we get the warning. This patch changes the order so that phys are
> unregistered before the bus device is deleted.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Salter <msalter@redhat.com> - 2015-09-01 15:40 +0200 Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() Florian Fainelli <f.fainelli@gmail.com> - 2015-09-01 16:00 +0200 Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Langsdorf <mlangsdo@redhat.com> - 2015-09-01 16:10 +0200 Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() David Miller <davem@davemloft.net> - 2015-09-02 00:10 +0200
csiph-web