Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1217115

Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister()

Show all headers | View raw

From: Mark Salter <msalter@redhat.com>
Date: Tue,  1 Sep 2015 09:36:05 -0400

> commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> the bus' parent.") uncovered a problem in mdiobus_unregister() which
> leads to this warning when I reboot an APM Mustang (arm64) platform:
 ...
> The problem is that mdiobus_unregister() deletes the bus device before
> unregistering the phy devices on the bus. This wasn't a problem before
> because the phys were not children of the bus:
> 
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0
> 
> But now that they are:
> 
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03
> 
> when mdiobus_unregister deletes the bus device, the phy subdirs are
> removed from sysfs also. So when the phys are unregistered afterward,
> we get the warning. This patch changes the order so that phys are
> unregistered before the bus device is deleted.
> 
> Signed-off-by: Mark Salter <msalter@redhat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Salter <msalter@redhat.com> - 2015-09-01 15:40 +0200
  Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() Florian Fainelli <f.fainelli@gmail.com> - 2015-09-01 16:00 +0200
  Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Langsdorf <mlangsdo@redhat.com> - 2015-09-01 16:10 +0200
  Re: [PATCH] phylib: fix device deletion order in  mdiobus_unregister() David Miller <davem@davemloft.net> - 2015-09-02 00:10 +0200

csiph-web