Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216192

Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit

Show all headers | View raw

On 08/31/2015 06:38 AM, Peter Zijlstra wrote:
> On Mon, Aug 31, 2015 at 06:26:00AM -0700, Guenter Roeck wrote:
>> On 08/31/2015 01:38 AM, Peter Zijlstra wrote:
>>> On Sun, Aug 30, 2015 at 05:53:22PM +0200, Borislav Petkov wrote:
>>>> On Sat, Aug 29, 2015 at 11:19:14AM +0200, Ingo Molnar wrote:
>>>>> So let me withdraw my ack: the much more important question that I
>>>>> missed first time around, why is this reporting feature living in
>>>>> hwmon, not in perf? We have energy reporting facilities in perf that
>>>>> this should be synced to.
>>>>
>>>> Because there's already fam15h_power driver which is exactly for that.
>>>> Making it part of perf is then a question of cat-ting the same sysfs
>>>> file twice, at the beginning and at the end of the trace, which is
>>>> trivial.
>>>
>>> That don't make sense.
>>>
>>> Looking at the BKDG Fam 15h 60h-6Fh these MSRs are per compute unit.
>>> This means you can do much finer grained measurements than system wide
>>> -- which is all hwmon seems capable of.
>>>
>>
>> Is it ? Why ?
>
> Dunno, because there's that big old loop iterating all cpus?
>

What does that have to do with 'hwmon' ? The current implementation in the
driver may not be a good idea, and maybe for good reasons; I can not
comment on that. However, you concluded from that implementation that
hwmon, the subsystem, would not be able to support 'much finer grained
measurements than system wide'. I would like to understand how you reached
that conclusion.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-28 08:50 +0200
  Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-28 10:10 +0200
  Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Ingo Molnar <mingo@kernel.org> - 2015-08-28 10:10 +0200
    Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-28 11:00 +0200
    Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Ingo Molnar <mingo@kernel.org> - 2015-08-29 11:20 +0200
      Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-30 18:00 +0200
        Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 10:40 +0200
          Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 15:30 +0200
            Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 15:40 +0200
              Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 16:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 17:20 +0200
          Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-31 18:10 +0200
            Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 18:20 +0200
              Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 22:50 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 23:30 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-09-01 18:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-09-01 18:10 +0200

csiph-web