Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215211

Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit

Show all headers | View raw

* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Aug 27, 2015 at 04:07:40PM +0800, Huang Rui wrote:
> > Add an accessor function amd_get_cores_per_cu() which returns the
> > number of cores per compute unit.
> > 
> > In a subsequent patch, we will use this function in fam15h_power
> > driver.
> > 
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >  arch/x86/include/asm/processor.h |  1 +
> >  arch/x86/kernel/cpu/amd.c        | 19 +++++++++++++++++--
> >  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> Btw, this needs an ACK from a tip person if it goes through the hwmon
> tree.

Looks good to me in theory.

I suspect we might want to factor the 'compute unit' logic out a bit more if usage 
becomes more widespread - but right now it's hwmon drivers only,right?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-28 08:50 +0200
  Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-28 10:10 +0200
  Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Ingo Molnar <mingo@kernel.org> - 2015-08-28 10:10 +0200
    Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-28 11:00 +0200
    Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Ingo Molnar <mingo@kernel.org> - 2015-08-29 11:20 +0200
      Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-30 18:00 +0200
        Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 10:40 +0200
          Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 15:30 +0200
            Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 15:40 +0200
              Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 16:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 17:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 17:20 +0200
          Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-08-31 18:10 +0200
            Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 18:20 +0200
              Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Peter Zijlstra <peterz@infradead.org> - 2015-08-31 22:50 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-08-31 23:30 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Borislav Petkov <bp@alien8.de> - 2015-09-01 18:00 +0200
                Re: [PATCH 09/15] x86, amd: add accessor for number of cores per  compute unit Guenter Roeck <linux@roeck-us.net> - 2015-09-01 18:10 +0200

csiph-web