Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Maxime Coquelin <maxime.coquelin@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
Date	Mon, 31 Aug 2015 10:50:02 +0200
Message-ID	<q3sWS-2B0-11@gated-at.bofh.it> (permalink)
References	<pK0eK-4WO-1@gated-at.bofh.it> <pK0eL-4WO-15@gated-at.bofh.it> <pKfdL-6cK-19@gated-at.bofh.it> <q3sat-1r5-1@gated-at.bofh.it> <q3sk9-1RI-7@gated-at.bofh.it>
X-Original-To	Paul Bolle <pebolle@tiscali.nl>, Peter Griffin <peter.griffin@linaro.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.201.21.241]
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-31_02:2015-08-27,2015-08-31,1970-01-01 signatures=0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	<lee.jones@linaro.org>, <devicetree@vger.kernel.org>, <dmaengine@vger.kernel.org>, <ludovic.barre@st.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <srinivas.kandagatla@gmail.com>, <patrice.chotard@st.com>, <vinod.koul@intel.com>, <dan.j.williams@intel.com>
X-Original-Date	Mon, 31 Aug 2015 10:44:40 +0200
X-Original-Message-ID	<55E413F8.6070307@st.com>
X-Original-References	<1436371888-27863-1-git-send-email-peter.griffin@linaro.org> <1436371888-27863-4-git-send-email-peter.griffin@linaro.org> <1436429872.20619.77.camel@tiscali.nl> <55E40715.1040204@st.com> <1441008481.8272.10.camel@tiscali.nl>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1216109

Show key headers only | View raw


On 08/31/2015 10:08 AM, Paul Bolle wrote:
> Hi Maxime,
>
> On ma, 2015-08-31 at 09:49 +0200, Maxime Coquelin wrote:
>> On 07/09/2015 10:17 AM, Paul Bolle wrote:
>>>>> +static int __exit st_fdma_remove(struct platform_device *pdev)
>>>>> +{
>>>>> +	struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
>>>>> +
>>>>> +	wait_for_completion(&fdev->fw_ack);
>>>>> +
>>>>> +	st_fdma_clk_disable(fdev);
>>>>> +
>>>>> +	return 0;
>>>>> +}
>>> Since this driver is built-in only this means st_fdma_remove() can
>>> never be used, right?
>> It's not because a driver is built-in only that it does not need a
>> remove callback.
>> An instance can be probed/removed any time via driver's bind/unbind
>> SysFS entries.
>> Am I missing something?
> (This discussion is moot because Peter already stated that a new version
> will be modular.)
>
> It follows from the __exit tag that st_fdma_remove() should never be
> part of the kernel image (in this version of the patch), doesn't it?
Yes, you are right.
The remove callback is relevant, but without the __exit tag.
>
> (I don't know what happens in this situation if an unbind sysfs entry is
> used to remove a driver. I've never tried that.)
>
>
Not checked whether the function is omitted when built-in, but in any 
case, I thnk remove callbacks should not be tagged with __exit.

Regards,
Maxime


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Maxime Coquelin <maxime.coquelin@st.com> - 2015-08-31 10:00 +0200
  Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Paul Bolle <pebolle@tiscali.nl> - 2015-08-31 10:10 +0200
    Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Maxime Coquelin <maxime.coquelin@st.com> - 2015-08-31 10:50 +0200

csiph-web