Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support

From	Maxime Coquelin <maxime.coquelin@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
Date	2015-08-31 10:00 +0200
Message-ID	<q3sat-1r5-1@gated-at.bofh.it> (permalink)
References	<pK0eK-4WO-1@gated-at.bofh.it> <pK0eL-4WO-15@gated-at.bofh.it> <pKfdL-6cK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Paul,

On 07/09/2015 10:17 AM, Paul Bolle wrote:
>> >+static int __exit st_fdma_remove(struct platform_device *pdev)
>> >+{
>> >+	struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
>> >+
>> >+	wait_for_completion(&fdev->fw_ack);
>> >+
>> >+	st_fdma_clk_disable(fdev);
>> >+
>> >+	return 0;
>> >+}
> Since this driver is built-in only this means st_fdma_remove() can never
> be used, right?
>

It's not because a driver is built-in only that it does not need a 
remove callback.
An instance can be probed/removed any time via driver's bind/unbind 
SysFS entries.
Am I missing something?

Kind regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Maxime Coquelin <maxime.coquelin@st.com> - 2015-08-31 10:00 +0200
  Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Paul Bolle <pebolle@tiscali.nl> - 2015-08-31 10:10 +0200
    Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Maxime Coquelin <maxime.coquelin@st.com> - 2015-08-31 10:50 +0200

csiph-web