Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215487

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

Show all headers | View raw

On Thu, Aug 27, 2015 at 02:33:06PM -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 26 Aug 2015, Joe Perches wrote:
> > vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
> > no_printk which produces no logging output but always
> > evaluates arguments.
> > 
> > Change the macro to surround the no_printk call with
> > 	do { if (0) no_printk(...); } while (0)
> > to avoid the unnecessary argument evaluations.
> > 
> > $ size drivers/platform/x86/thinkpad_acpi.o*
> >    text	   data	    bss	    dec	    hex	filename
> >   60918	   6184	    824	  67926	  10956	drivers/platform/x86/thinkpad_acpi.o.new
> >   60927	   6184	    824	  67935	  1095f	drivers/platform/x86/thinkpad_acpi.o.old
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Queued, thanks.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Joe Perches <joe@perches.com> - 2015-08-26 20:20 +0200
  Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-26 20:30 +0200
    Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Joe Perches <joe@perches.com> - 2015-08-26 20:40 +0200
      Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-27 19:40 +0200
  Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-27 19:40 +0200
    Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Darren Hart <dvhart@infradead.org> - 2015-08-28 20:00 +0200

csiph-web