Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214109

Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

Show all headers | View raw

On Wed, Aug 26, 2015, at 15:13, Joe Perches wrote:
> vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
> no_printk which produces no logging output but always
> evaluates arguments.
> 
> Change the macro to surround the no_printk call with
> 	do { if (0) no_printk(...); } while (0)
> to avoid the unnecessary argument evaluations.
> 
> $ size drivers/platform/x86/thinkpad_acpi.o*
>    text       data     bss     dec     hex filename
>   60918      6184     824   67926   10956
>   drivers/platform/x86/thinkpad_acpi.o.new
>   60927      6184     824   67935   1095f
>   drivers/platform/x86/thinkpad_acpi.o.old

The code size savings of this change are really small...

> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -402,7 +402,7 @@ static const char *str_supported(int is_supported);
>  #else
>  static inline const char *str_supported(int is_supported) { return ""; }
>  #define vdbg_printk(a_dbg_level, format, arg...)        \
> -       no_printk(format, ##arg)
> +       do { if (0) no_printk(format, ##arg); } while (0)
>  #endif

And won't this change disable compile-time checking of 'format ## arg'
for issues?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Joe Perches <joe@perches.com> - 2015-08-26 20:20 +0200
  Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-26 20:30 +0200
    Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Joe Perches <joe@perches.com> - 2015-08-26 20:40 +0200
      Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-27 19:40 +0200
  Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2015-08-27 19:40 +0200
    Re: [PATCH] thinkpad_acpi: Remove side effects from vdbg_printk ->  no_printk macro Darren Hart <dvhart@infradead.org> - 2015-08-28 20:00 +0200

csiph-web