Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215219

Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range()

Show all headers | View raw

On 08/27/2015 11:06 PM, Ingo Molnar wrote:
>
> * Luis R. Rodriguez <mcgrof@do-not-panic.com> wrote:
>
>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>>
>> S390 requires its own implementation of pcio_iomap*() calls
>> is because it has its "BAR spaces are not disjunctive on s390
>> so we need the bar parameter of pci_iomap to find the corresponding
>> device and create the mapping cookie" -- in summary, it has its own
>> lookup/lock solution.
>>
>> It does not include asm-generic/pci_iomap.h
>>
>> Since it currenty maps ioremap_wc() to ioremap_nocache() and that's
>> the architecture default we can easily just map the wc calls to
>> the default calls as well.
>>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Borislav Petkov <bp@suse.de>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: Fengguang Wu <fengguang.wu@intel.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> Reported-by: 0 day bot
>> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
>> ---
>>
>> This broke through some series that went into Ingo's tip tree which
>> I added. As such I *think* this should go through Ingo's tip tree.
>> Let me know. Up to you guys.
>
> I fixed the changelog to explain all this.
>
> Also, is there any other architecture that got broken by:
>
>     1b3d4200c1e0 PCI: Add pci_iomap_wc() variants
>

Should be the only one. There are only two implementations of pci_iomap(),
one in s390 code and the generic implementation.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() "Luis R. Rodriguez" <mcgrof@do-not-panic.com> - 2015-08-27 01:40 +0200
  Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() Ingo Molnar <mingo@kernel.org> - 2015-08-28 08:10 +0200
    Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() Guenter Roeck <linux@roeck-us.net> - 2015-08-28 10:30 +0200
      Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() "Luis R. Rodriguez" <mcgrof@suse.com> - 2015-08-29 02:20 +0200
  [tip:x86/mm] s390/io: Add pci_iomap_wc() and pci_iomap_wc_range() "tip-bot for Luis R. Rodriguez" <tipbot@zytor.com> - 2015-08-28 08:50 +0200

csiph-web