Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1212942
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Lee Jones <lee.jones@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue |
| Date | Tue, 25 Aug 2015 12:40:02 +0200 |
| Message-ID | <q1jO2-3RS-7@gated-at.bofh.it> (permalink) |
| References | <q158m-7Qs-7@gated-at.bofh.it> <q158m-7Qs-5@gated-at.bofh.it> <q1hsS-Dz-11@gated-at.bofh.it> <q1i5A-1mK-5@gated-at.bofh.it> |
| X-Original-To | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=sMPosdQ3tFLSbUVvDuzmULrbHq7+mhHkmZ6mMN/EviY=; b=ZAms8XjQKY408AkpLQj9eOOQx5P1xoBWP1c3nyAgGxkizHFM3HdogBVcCylnW2D7k2 76AtxHEqzW5mSDW/AcMCIH3km3soahuDabadb0H9bXdF6UJwARRy/OlMnY92AkaFmxJl +2wWjnAnHTVDX1E4TVIK3fXLP8idRBfDiR/cdczEMGBYWX8LWdpoA81CTW0I5aTAgfar 4mH+7xYtOXiFORYM3nKqg8rjn8hVk+Q939DeXFaLR+lKGbJoDrG3zGZ8NAnGRvG/Fe9k 5MN1LXIn4j50kQrSgqPXGQgxh0kl2ahYTqsurhAUVoX02u7PrDRurmFbQjJZBjdhH30i YkTg== |
| X-Gm-Message-State | ALoCoQm1C62vgkuBjZPCX3+jqdmLfOxlQKNyF3xJh7dwgDaUaIf+bbr7CVBLyUPGd5/79MCaKDuj |
| X-Received | by 10.180.189.17 with SMTP id ge17mr3445188wic.90.1440498622697; Tue, 25 Aug 2015 03:30:22 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| Content-Transfer-Encoding | 8bit |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 63 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org |
| X-Original-Date | Tue, 25 Aug 2015 11:30:19 +0100 |
| X-Original-Message-ID | <20150825103019.GP19409@x1> |
| X-Original-References | <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-2-git-send-email-vaibhav.hiremath@linaro.org> <20150825075121.GE19409@x1> <55DC2A51.6090008@linaro.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1212942 |
Show key headers only | View raw
On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: > >On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > > > >>Driver had coding style issues where spaces were used instead > >>of tabs. This patch fixes them all. > > > >That's not all it's doing though is it? > > > > Yes, its just tabbing related fixes. No, it's really not. > >Please describe all of your changes. ... we're also taking the opportunity to remove the unnecessary protection surrounding some of the defined values. > >>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > >>--- > >> drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++-------------------------- > >> 1 file changed, 61 insertions(+), 64 deletions(-) > >> > >>diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > >>index f104a32..c4e097d 100644 > >>--- a/drivers/mfd/88pm800.c > >>+++ b/drivers/mfd/88pm800.c > >>@@ -30,55 +30,55 @@ > >> #include <linux/of_device.h> > >> > >> /* Interrupt Registers */ > >>-#define PM800_INT_STATUS1 (0x05) > >>+#define PM800_INT_STATUS1 0x05 > >> #define PM800_ONKEY_INT_STS1 (1 << 0) > >> #define PM800_EXTON_INT_STS1 (1 << 1) > >>-#define PM800_CHG_INT_STS1 (1 << 2) > >>-#define PM800_BAT_INT_STS1 (1 << 3) > >>-#define PM800_RTC_INT_STS1 (1 << 4) > >>+#define PM800_CHG_INT_STS1 (1 << 2) > >>+#define PM800_BAT_INT_STS1 (1 << 3) > >>+#define PM800_RTC_INT_STS1 (1 << 4) > >> #define PM800_CLASSD_OC_INT_STS1 (1 << 5) > > > >These should all be replaced by BIT(). > > > >Please fix the whole file. > > Will do. > > Thanks, > Vaibhav -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 21:00 +0200
Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 10:10 +0200
Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 10:50 +0200
Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 12:40 +0200
Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 12:50 +0200
csiph-web