Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

From	Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue
Date	2015-08-25 12:50 +0200
Message-ID	<q1jXI-43u-7@gated-at.bofh.it> (permalink)
References	<q158m-7Qs-7@gated-at.bofh.it> <q158m-7Qs-5@gated-at.bofh.it> <q1hsS-Dz-11@gated-at.bofh.it> <q1i5A-1mK-5@gated-at.bofh.it> <q1jO2-3RS-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>> On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote:
>>> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>>>
>>>> Driver had coding style issues where spaces were used instead
>>>> of tabs. This patch fixes them all.
>>>
>>> That's not all it's doing though is it?
>>>
>>
>> Yes, its just tabbing related fixes.
>
> No, it's really not.
>
>>> Please describe all of your changes.
>
> ... we're also taking the opportunity to remove the unnecessary
> protection surrounding some of the defined values.
>

Ohhh ok. Forgot about brackets :)

Anyway,
Based on the comments you provided, I think both header file and
source file needs some more cleanup.
I will try to incorporate all changes in next version.

I may also submit separate series for cleanup version (depends on
patches I produce).

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 21:00 +0200
  Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 10:10 +0200
    Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 10:50 +0200
      Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 12:40 +0200
        Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 12:50 +0200

csiph-web