RE: [PATCH] IGMP: Inhibit reports for local multicast groups

From	Philip Downey <pdowney@Brocade.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] IGMP: Inhibit reports for local multicast groups
Date	2015-08-26 11:30 +0200
Message-ID	<q1FbQ-1C1-1@gated-at.bofh.it> (permalink)
References	<cfJU1-2xS-5@gated-at.bofh.it> <q0Yqe-6D0-13@gated-at.bofh.it> <q1tX4-1RJ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, August 25, 2015 10:20 PM
> To: Philip Downey
> Cc: kuznet@ms2.inr.ac.ru; jmorris@namei.org; yoshfuji@linux-ipv6.org;
> kaber@trash.net; linux-kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups
> 
> From: Philip Downey <pdowney@brocade.com>
> Date: Mon, 24 Aug 2015 12:39:17 +0100
> 
> > +extern int sysctl_igmp_link_local_reports;
>  ...
> > +/* IGMP reports for link-local multicast groups are enabled by default */
> > +#define IGMP_ENABLE_LLM         1
> > +
> > +int sysctl_igmp_link_local_reports __read_mostly = IGMP_ENABLE_LLM;
> > +
> > +#define IGMP_INHIBIT_LINK_LOCAL_REPORTS(_ipaddr) \
> > +	(ipv4_is_local_multicast(_ipaddr) && \
> > +	 (sysctl_igmp_link_local_reports == 0))
> > +
> 
> People know that "1" and "0" means enable and disable respectively, so this
> macros is pretty excessive.  Just remove it.
> 
> Also, simplify the name of the sysctl to something like
> "sysctl_igmp_llm_reports" or similar, and simplify the test against 0 to be in
> the canonical "!x" format.  Then the test can fit on one
> line:
> 
> 	(ipv4_is_local_multicast(_ipaddr) && !sysctl_igmp_llm_reports).

Thanks for reviewing David.
I will make the requested changes  (fitting the test on a single line was my main reason for introducing the macro - that and making it patently obvious what the test was doing.  Your suggestion would seem to meet that aim).

Will amend and resubmit.

Regards

Philip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IGMP: Inhibit reports for local multicast groups Philip Downey <pdowney@brocade.com> - 2015-08-24 13:50 +0200
  Re: [PATCH] IGMP: Inhibit reports for local multicast groups David Miller <davem@davemloft.net> - 2015-08-25 23:30 +0200
    RE: [PATCH] IGMP: Inhibit reports for local multicast groups Philip Downey <pdowney@Brocade.com> - 2015-08-26 11:30 +0200

csiph-web