Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

Path	csiph.com!usenet.pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From	Akinobu Mita <akinobu.mita@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus
Date	Sat, 22 Aug 2015 05:00:02 +0200
Message-ID	<q07ce-645-3@gated-at.bofh.it> (permalink)
References	<pZyxQ-6Jf-15@gated-at.bofh.it> <pZyxQ-6Jf-13@gated-at.bofh.it> <pZHKO-3f1-13@gated-at.bofh.it> <q02YV-9v-15@gated-at.bofh.it>
X-Original-To	Yaniv Gardi <ygardi@codeaurora.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aZUOrp6Cik4TnuwPWOito/9tIaS0HXpIGugC3AXd6aY=; b=XhDvL7/OSSEK78wi4no/USVaiKUNTtYoRD24j0ewzWlIZvAHVVJGyVCpknGMBMuQUb QaloSiRLBuzcfByN6ugVJacQpg33ToBVgXcCbcUvgitPovuKbHWOHxp7EPfZCeZ5xXjG jgaOOaqb2Lj6wgCYZ9IcGmvZ3jVTPjH8G4bFQs1q3cBE8dpup1TcJCldeelqJthJu9Hu GyF3XlIcSTYbCYLSmTi2UVYOHROD5LzvvSXIbkeuIdOM5Kh4varldX3VOkdFVFbdgdHj 8c6ysiiWxoQUpIEL0h4KZjCD7g/IiV//QW1ONL9wk/04eivL6wH0QGpVLYO+tLbxmDrH 8/9A==
MIME-Version	1.0
X-Received	by 10.52.243.232 with SMTP id xb8mr14560656vdc.40.1440212175039; Fri, 21 Aug 2015 19:56:15 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robherring2@gmail.com>, Jej B <james.bottomley@hansenpartnership.com>, Paul Bolle <pebolle@tiscali.nl>, Christoph Hellwig <hch@infradead.org>, LKML <linux-kernel@vger.kernel.org>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, linux-arm-msm@vger.kernel.org, Santosh Y <santoshsy@gmail.com>, linux-scsi-owner@vger.kernel.org, Subhash Jadavani <subhashj@codeaurora.org>, Gilad Broner <gbroner@codeaurora.org>, Dolev Raviv <draviv@codeaurora.org>, Vinayak Holikatti <vinholikatti@gmail.com>, "James E.J. Bottomley" <jbottomley@odin.com>
X-Original-Date	Sat, 22 Aug 2015 11:56:14 +0900
X-Original-Message-ID	<CAC5umyj8i2N3Xzdqye2mQY3WF5MbpEm61LjO0HYMk-mvbUnL7A@mail.gmail.com>
X-Original-References	<1440079144-26461-1-git-send-email-ygardi@codeaurora.org> <1440079144-26461-8-git-send-email-ygardi@codeaurora.org> <CAC5umyhRBDW0OxmDiw9TMHNm-kz1f_wcE0iZ3dY=MkfnMywUNw@mail.gmail.com> <545cd2cdf947a2a59f5d021c27bdc78f.squirrel@www.codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1211394

Show key headers only | View raw

2015-08-22 7:23 GMT+09:00  <ygardi@codeaurora.org>:
>> 2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
>>> @@ -30,6 +48,14 @@ static void ufs_qcom_get_speed_mode(struct
>>> ufs_pa_layer_attr *p, char *result);
>>>  static int ufs_qcom_get_bus_vote(struct ufs_qcom_host *host,
>>>                 const char *speed_mode);
>>>  static int ufs_qcom_set_bus_vote(struct ufs_qcom_host *host, int vote);
>>> +static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host
>>> *host);
>>> +static void ufs_qcom_dump_regs(struct ufs_hba *hba, int offset, int
>>> len,
>>> +               char *prefix)
>>> +{
>>> +       print_hex_dump(KERN_ERR, prefix,
>>> +                       len > 4 ? DUMP_PREFIX_OFFSET : DUMP_PREFIX_NONE,
>>> +                       16, 4, hba->mmio_base + offset, len * 4, false);
>>> +}
>>
>> This causes a sparse warning as __iomem pointer is passed to
>> print_hex_dump().
>
> indeed.
> any suggestions how it can be fixed ? I guess I shall try casting.

I think introducing generic print_hex_dump_io() library function
is useful for this and other drivers want to use it.  But for now we can just
create simple local dump function which readl() and print for each register.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-20 16:00 +0200
  Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-21 01:50 +0200
    Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus ygardi@codeaurora.org - 2015-08-22 00:30 +0200
      Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-22 05:00 +0200
  Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-22 05:10 +0200
    Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus ygardi@codeaurora.org - 2015-08-23 11:00 +0200

csiph-web