Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211394

Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

Show all headers | View raw

2015-08-22 7:23 GMT+09:00  <ygardi@codeaurora.org>:
>> 2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>:
>>> @@ -30,6 +48,14 @@ static void ufs_qcom_get_speed_mode(struct
>>> ufs_pa_layer_attr *p, char *result);
>>>  static int ufs_qcom_get_bus_vote(struct ufs_qcom_host *host,
>>>                 const char *speed_mode);
>>>  static int ufs_qcom_set_bus_vote(struct ufs_qcom_host *host, int vote);
>>> +static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host
>>> *host);
>>> +static void ufs_qcom_dump_regs(struct ufs_hba *hba, int offset, int
>>> len,
>>> +               char *prefix)
>>> +{
>>> +       print_hex_dump(KERN_ERR, prefix,
>>> +                       len > 4 ? DUMP_PREFIX_OFFSET : DUMP_PREFIX_NONE,
>>> +                       16, 4, hba->mmio_base + offset, len * 4, false);
>>> +}
>>
>> This causes a sparse warning as __iomem pointer is passed to
>> print_hex_dump().
>
> indeed.
> any suggestions how it can be fixed ? I guess I shall try casting.

I think introducing generic print_hex_dump_io() library function
is useful for this and other drivers want to use it.  But for now we can just
create simple local dump function which readl() and print for each register.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-20 16:00 +0200
  Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-21 01:50 +0200
    Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus ygardi@codeaurora.org - 2015-08-22 00:30 +0200
      Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-22 05:00 +0200
  Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus Akinobu Mita <akinobu.mita@gmail.com> - 2015-08-22 05:10 +0200
    Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus ygardi@codeaurora.org - 2015-08-23 11:00 +0200

csiph-web