Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test
Date	2015-06-11 00:40 +0200
Message-ID	<pzWP7-3fi-11@gated-at.bofh.it> (permalink)
References	<pzRw6-3P7-27@gated-at.bofh.it> <pzUtZ-8mU-37@gated-at.bofh.it> <pzUNk-ir-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 10 Jun 2015 22:15:58 +0200
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> On 06/10/2015 10:00 PM, Kees Cook wrote:
> >> +       printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
> >> +       exit(0); /* this is not a test failure */
> > 
> > Why is that not a test failure? It would mean it didn't actually test
> > anything, which seems like a failure to me.
> 
> Are you objecting to comment wording, or to exiting with 0?
> 
> I exit with 0 because no bug was detected.

I believe there's a way to exit with "not supported". That's what the
ftrace tests do.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test Steven Rostedt <rostedt@goodmis.org> - 2015-06-11 00:40 +0200

csiph-web