Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API
Date	2015-06-07 01:10 +0200
Message-ID	<pyvnX-6dC-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <py1pT-3Kb-21@gated-at.bofh.it> <pytFw-3E8-7@gated-at.bofh.it> <pytYR-414-11@gated-at.bofh.it> <pyuUV-5nv-3@gated-at.bofh.it> <pyv4C-5z0-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/07, Jiri Kosina wrote:
>
> On Sun, 7 Jun 2015, Oleg Nesterov wrote:
>
> > > I personally don't see a huge principal difference between
> > > "kthread_signal_dequeue() + kthread_do_signal_{stop,...}" vs. generic
> > > "kthread_do_signal()" that's just basically completely general and
> > > takes care of 'everything necessary'.
> >
> > Then why do we need the new API ?
>
> Well, in a nutshell, because of the "it's general and takes care of
> everything" part.

...

> Signal handling is just
> one of the piggy-backers on top of this general cleanup.

And to avoid the confusion: so far I only argued with the signal
handling part of this API. Namely with kthread_do_signal(), especially
with the SIG_DFL logic.

If we want somthing like kthread_iterant agree it should probably help to
handle the signals too. But afaics kthread_do_signal() doesn't really help
and certainly it is not strictly necessary.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into  the iterant API Oleg Nesterov <oleg@redhat.com> - 2015-06-06 23:20 +0200
  Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the  iterant API Jiri Kosina <jkosina@suse.cz> - 2015-06-06 23:40 +0200
    Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into  the iterant API Oleg Nesterov <oleg@redhat.com> - 2015-06-07 00:40 +0200
      Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the  iterant API Jiri Kosina <jkosina@suse.cz> - 2015-06-07 00:50 +0200
        Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into  the iterant API Oleg Nesterov <oleg@redhat.com> - 2015-06-07 01:10 +0200

csiph-web