[PATCH v2] [SCSI] qla4xxx: Replace __constant_cpu_to_le16 with cpu_to_le16

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Vaishali Thakkar <vthakkar1994@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] [SCSI] qla4xxx: Replace __constant_cpu_to_le16 with cpu_to_le16
Date	Sat, 06 Jun 2015 02:50:02 +0200
Message-ID	<pyatc-vK-5@gated-at.bofh.it> (permalink)
X-Original-To	"James E.J. Bottomley" <JBottomley@odin.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=CWH2l+DXcC5FFjUMjCbOB1M5na7pvrcpn5E37bAZoaQ=; b=SILb3hozb0dIK1kCPPx5SzhamWbbZh9dibv0NSEWJWcIp7nIa0hk6WT3LcXgE+BFt2 7zGlKF8JW3/iKKiNJWZt/+DnI0N+xKefTh35lrzCbw3kp7JZ88ppLGvcD7jNwBQuzNBC pBstiJDEtRPsi+0RdHQaPcQypW5ObPr0GMA8N5i336N3rVNA8N5XEgifSv99hRY05UzB WgPr+TU+hWrV1tN31HxoNSHZF4tYo+9OzEIM4lS+XLOtl4GYWO+9XER/Rh+MAL+9RTlx n22xmuHb7pcRXtelQO8fGsxLy42JXa3xErqpNKaYOHoAio7iwmuJAFRpLwgBhbSIpVt7 ESOw==
X-Received	by 10.70.132.195 with SMTP id ow3mr9708401pdb.87.1433551517923; Fri, 05 Jun 2015 17:45:17 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
X-Original-Date	Sat, 6 Jun 2015 06:15:12 +0530
X-Original-Message-ID	<20150606004512.GA8197@vaishali-Ideapad-Z570>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1159800

Show key headers only | View raw

In big endian cases, macro cpu_to_le16 unfolds to __swab16 which
provides special case for constants. In little endian cases,
__constant_cpu_to_le16 and cpu_to_le16 expand directly to the
same expression. So, replace __constant_cpu_to_le16 with
cpu_to_le16 with the goal of getting rid of the definition of
__constant_cpu_to_le16 completely.

The semantic patch that performs this transformation is as follows:

@@expression x;@@

- __constant_cpu_to_le16(x)
+ cpu_to_le16(x)

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
Changes since v1:
	- Make subject more concise
---
 drivers/scsi/qla4xxx/ql4_nx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
index 7c33658..06d6cce 100644
--- a/drivers/scsi/qla4xxx/ql4_nx.c
+++ b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -3741,9 +3741,9 @@ qla4_8xxx_get_flt_info(struct scsi_qla_host *ha, uint32_t flt_addr)
 			goto no_flash_data;
 	}
 
-	if (*wptr == __constant_cpu_to_le16(0xffff))
+	if (*wptr == cpu_to_le16(0xffff))
 		goto no_flash_data;
-	if (flt->version != __constant_cpu_to_le16(1)) {
+	if (flt->version != cpu_to_le16(1)) {
 		DEBUG2(ql4_printk(KERN_INFO, ha, "Unsupported FLT detected: "
 			"version=0x%x length=0x%x checksum=0x%x.\n",
 			le16_to_cpu(flt->version), le16_to_cpu(flt->length),
@@ -3846,7 +3846,7 @@ qla4_82xx_get_fdt_info(struct scsi_qla_host *ha)
 	qla4_82xx_read_optrom_data(ha, (uint8_t *)ha->request_ring,
 	    hw->flt_region_fdt << 2, OPTROM_BURST_SIZE);
 
-	if (*wptr == __constant_cpu_to_le16(0xffff))
+	if (*wptr == cpu_to_le16(0xffff))
 		goto no_flash_data;
 
 	if (fdt->sig[0] != 'Q' || fdt->sig[1] != 'L' || fdt->sig[2] != 'I' ||
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] [SCSI] qla4xxx: Replace __constant_cpu_to_le16 with  cpu_to_le16 Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-06-06 02:50 +0200

csiph-web