Re: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for direct IO

From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for direct IO
Date	2015-06-06 02:50 +0200
Message-ID	<pyatc-vK-7@gated-at.bofh.it> (permalink)
References	<pvm7v-3Bp-3@gated-at.bofh.it> <pvm7v-3Bp-11@gated-at.bofh.it> <py1pU-3Kb-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 5, 2015 at 11:03 PM, Christoph Hellwig <hch@infradead.org> wrote:
> As mentioned last time a big fat NAK for this one.  We generally
> do not dirty kernel pages anywhere, so a flag that must alway be set
> for default behavior just to prepare for a highy hypothetical user that
> in the future might want to abuse the interface is a no-go.
>
> Just make the dirtying behavior dependent on the iov_iter type:
> dirty for ITER_IOVEC and do nothing for ITER_KVEC and ITER_BVEC.

Both ITER_KVEC and ITER_BVEC doesn't mean the pages are kernel
page, for example of loop and swap. That is why this patch is more flexiable,
and won't cause regression since the users may have different dirtying
rules as you mentioned last time.

http://marc.info/?t=143093223200001&r=1&w=2

Thanks,
Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for  direct IO Ming Lei <ming.lei@canonical.com> - 2015-06-06 02:50 +0200

csiph-web