Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1160193

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From David Decotigny <ddecotig@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion
Date Mon, 08 Jun 2015 02:50:02 +0200
Message-ID <pyTqi-7sH-5@gated-at.bofh.it> (permalink)
References <pyTqi-7sH-3@gated-at.bofh.it>
X-Original-To Larry Finger <Larry.Finger@lwfinger.net>, Jes Sorensen <Jes.Sorensen@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Em20Txa7TxBeTep9n1nlmNbAx+Jg2xD0TdKlbgefDpg=; b=rIWzn/Aap4qoBrRqk8RZQ6bGSodR6aNoOtkOBk12eqgwJBUnyT8TmulzlNkBdI3sca eH3QCqzSf9e0cu/80S7QbU3NZLA9Lyvyo1SZGkYRCGOLjHsfnAwso8ta49Gs+RNlVSU3 7iaR1TCsWsk7xS4TQ+KvwC5ANOe3RE14tHnDWzUOQfM5GurW1rgqN8mKsohHAcsBG9cG 33DzcgLm4ay+vdeyFbFcCO20P8CnndbhjsHjxd4xUR3SBpQJPslR4vE1lZuAS7420J5a w1v99a3YXzuApdooKSjZ/OAOEMhi/rdIxFs3XGvKsL9KfU5NvunZJrDSn96GFyvh+8oc VKmg==
X-Received by 10.229.188.137 with SMTP id da9mr17393031qcb.27.1433724196831; Sun, 07 Jun 2015 17:43:16 -0700 (PDT)
X-Mailer git-send-email 2.2.0.rc0.207.ga3a616c
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc Joe Perches <joe@perches.com>, Dan Carpenter <dan.carpenter@oracle.com>, David Decotigny <ddecotig@gmail.com>
X-Original-Date Sun, 7 Jun 2015 17:43:02 -0700
X-Original-Message-ID <1433724182-657-3-git-send-email-ddecotig@gmail.com>
X-Original-References <1433724182-657-1-git-send-email-ddecotig@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1160193

Show key headers only | View raw


Source and destination have the same little-endian annotation: this
patch removes incorrect byte-swap on non-LE cpus.

This addresses the following sparse warning:
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base types)
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:    expected unsigned short [unsigned] [usertype] val
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:    got restricted __le16 [usertype] BA_timeout_value

Signed-off-by: David Decotigny <ddecotig@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 7c3b5dd..142f214 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -3906,8 +3906,8 @@ void issue_action_BA23a(struct rtw_adapter *padapter,
 		put_unaligned_le16(BA_para_set,
 				   &mgmt->u.action.u.addba_resp.capab);
 
-		put_unaligned_le16(pmlmeinfo->ADDBA_req.BA_timeout_value,
-				   &mgmt->u.action.u.addba_resp.timeout);
+		mgmt->u.action.u.addba_resp.timeout
+			= pmlmeinfo->ADDBA_req.BA_timeout_value;
 
 		pattrib->pktlen += 8;
 		break;
-- 
2.2.0.rc0.207.ga3a616c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues David Decotigny <ddecotig@gmail.com> - 2015-06-08 02:50 +0200
  [PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion David Decotigny <ddecotig@gmail.com> - 2015-06-08 02:50 +0200

csiph-web