Re: [PATCH v2] drivers: of/base: move of_init to driver_init

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Rob Herring <robherring2@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drivers: of/base: move of_init to driver_init
Date	Mon, 08 Jun 2015 02:30:01 +0200
Message-ID	<pyT6V-75X-1@gated-at.bofh.it> (permalink)
References	<ppXCO-3Ub-13@gated-at.bofh.it> <pq2j8-2p1-13@gated-at.bofh.it> <prOOJ-6hE-1@gated-at.bofh.it> <prTlp-4JY-21@gated-at.bofh.it> <pyMf7-5Bc-19@gated-at.bofh.it>
X-Original-To	Grant Likely <grant.likely@linaro.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=MnoqwzUkmRo4HHdsrqCAzpDxa7SKbw1SFUk1me8lFTs=; b=Rd2imzD7kR3+1Z1ALressYdpAbRA2lDoeiuYyTwBoyWYV273Kr71c7+Rjf+GmMig92 2mWE2UlRIlxbp5gNRukUJqIVPFSl27QLshf/NZmXzJkhMBJph32hXPQ22UifJeZeiWhD 4ByergzJnwNf2ls921sefLcvTWBiMlRq0L/YLJXA7T5tfHCCSMZqaG2rTHvdYa0lstyJ UI4Ajvkkcar/EIoYjMNo2uszFavQXKAzcjlbGmRsa3gTQjVtZ1n2SB3uG6xnpz1T4PkS oUfhBRuFO7RFoB4UK89gzqpykFgpK0/4PWftY9Q90DD/G4d84YPlqDrRfAV2UtP2DsK7 xuog==
X-Received	by 10.52.230.2 with SMTP id su2mr26485642vdc.55.1433723378328; Sun, 07 Jun 2015 17:29:38 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sudeep Holla <sudeep.holla@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>
X-Original-Date	Sun, 7 Jun 2015 19:29:17 -0500
X-Original-Message-ID	<CAL_JsqKEcpWiPsORFrQs+dhqM4qcgMPyaz0ijVEMNkFeVQfkWQ@mail.gmail.com>
X-Original-References	<1431595695-17103-1-git-send-email-sudeep.holla@arm.com> <1431613704-30801-1-git-send-email-sudeep.holla@arm.com> <555B2C9C.1000709@arm.com> <20150519171732.GD9213@kroah.com> <20150607070539.A8C7EC409D1@trevor.secretlab.ca>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1160189

Show key headers only | View raw

On Sun, Jun 7, 2015 at 2:05 AM, Grant Likely <grant.likely@linaro.org> wrote:
> On Tue, 19 May 2015 10:17:32 -0700
> , Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>  wrote:
>> On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote:
>> > Hi Rob/Greg,
>> >
>> > On 14/05/15 15:28, Sudeep Holla wrote:
>> > >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
>> > >devices with an OF node") adds the symlink `of_node` for each device
>> > >pointing to it's device tree node while creating/initialising it.
>> > >
>> > >However the devicetree sysfs is created and setup in of_init which is
>> > >executed at core_initcall level. For all the devices created before
>> > >of_init, the following error is thrown:
>> > >   "Error -2(-ENOENT) creating of_node link"
>> > >
>> > >Like many other components in driver model, initialize the sysfs support
>> > >for OF/devicetree from driver_init so that it's ready before any devices
>> > >are created.
>> > >
>> > >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
>> > >   devices with an OF node")
>> > >Suggested-by: Rob Herring <robh+dt@kernel.org>
>> > >Cc: Grant Likely <grant.likely@linaro.org>
>> > >Cc: Rob Herring <robh+dt@kernel.org>
>> > >Cc: Pawel Moll <pawel.moll@arm.com>
>> > >Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> > >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> > >Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> >
>> > I assume one of you will pick this up if there are no further comments ?
>>
>> I will once things settle down...
>
> I've picked it up. Yell if you'd prefer to take it by your tree.

Greg already applied it. It just hit Linus' tree Sat.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] drivers: of/base: move of_init to driver_init Rob Herring <robherring2@gmail.com> - 2015-06-08 02:30 +0200

csiph-web