Re: [RFC PATCH] perf: honoring cpuid for number of fixed counters

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] perf: honoring cpuid for number of fixed counters
Date	Thu, 04 Jun 2015 13:50:01 +0200
Message-ID	<pxBON-8al-3@gated-at.bofh.it> (permalink)
References	<pxbUl-3be-1@gated-at.bofh.it> <pxcno-3Pz-13@gated-at.bofh.it> <pxAJ4-6By-13@gated-at.bofh.it>
X-Original-To	Imre Palik <imrep.amz@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2012-12-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org, "Palik, Imre" <imrep@amazon.de>, Anthony Liguori <aliguori@amazon.com>
X-Original-Date	Thu, 4 Jun 2015 13:49:17 +0200
X-Original-Message-ID	<20150604114917.GI3644@twins.programming.kicks-ass.net>
X-Original-References	<1433318628-6330-1-git-send-email-imrep.amz@gmail.com> <20150603083615.GZ3644@twins.programming.kicks-ass.net> <557029DC.6080201@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1158489

Show key headers only | View raw

On Thu, Jun 04, 2015 at 12:35:08PM +0200, Imre Palik wrote:
> On 06/03/15 10:36, Peter Zijlstra wrote:
> > Further, the Intel Arch PerfMon v2 spec actually specifies there to be 3
> > fixed function counters.
> > 
> > So anything that says it is v2+ and does not have the 3, is non
> > compliant.
> >
> > I would suggest you go fix your hypervisor.
> 
> If I set up the hypervisor to advertise Arch PerfMon v1 (0 fixed
> counters), then  without my patch, perf still tries to use fixed
> counters.  So something is clearly broken here.

So the code you deleted does if (version > 1), and last I checked that
should return false if version == 1.

So please check what's happening there first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] perf: honoring cpuid for number of fixed counters Imre Palik <imrep.amz@gmail.com> - 2015-06-04 12:40 +0200
  Re: [RFC PATCH] perf: honoring cpuid for number of fixed counters Peter Zijlstra <peterz@infradead.org> - 2015-06-04 13:50 +0200

csiph-web