[PATCH] staging: fbtft: fix out of bound access

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: fbtft: fix out of bound access
Date	2015-06-04 13:50 +0200
Message-ID	<pxBON-8al-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

size of str is 16, but in snprintf the size was mentioned as 128.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index ce64521..0af84b5 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1096,7 +1096,7 @@ static int fbtft_init_display_dt(struct fbtft_par *par)
 			/* make debug message */
 			msg[0] = '\0';
 			for (j = 0; j < i; j++) {
-				snprintf(str, 128, " %02X", buf[j]);
+				snprintf(str, 16, " %02X", buf[j]);
 				strcat(msg, str);
 			}
 			fbtft_par_dbg(DEBUG_INIT_DISPLAY, par,
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fbtft: fix out of bound access Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-04 13:50 +0200
  Re: [PATCH] staging: fbtft: fix out of bound access Joe Perches <joe@perches.com> - 2015-06-04 14:20 +0200

csiph-web