Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU

Path	csiph.com!aioe.org!news.snarked.org!news.spin.it!bofh.it!news.nic.it!robomod
From	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU
Date	Thu, 04 Jun 2015 12:30:03 +0200
Message-ID	<pxAzp-6eI-41@gated-at.bofh.it> (permalink)
References	<pwWVk-6d0-7@gated-at.bofh.it> <pwWVl-6d0-39@gated-at.bofh.it> <px5cd-1n6-1@gated-at.bofh.it>
X-Original-To	Daniel Axtens <dja@axtens.net>
User-Agent	Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Tm-As-Mml	disable
X-Content-Scanned	Fidelis XPS MAILER
X-Cbid	15060410-4790-0000-0000-000008875E8B
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Stewart Smith <stewart@linux.vnet.ibm.com>, Stephane Eranian <eranian@google.com>, Paul Mackerras <paulus@samba.org>, Jeremy Kerr <jk@ozlabs.org>, Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>, Anshuman Khandual <khandual@linux.vnet.ibm.com>
X-Original-Date	Thu, 04 Jun 2015 15:56:44 +0530
X-Original-Message-ID	<557027E4.7010601@linux.vnet.ibm.com>
X-Original-References	<1433260778-26497-1-git-send-email-maddy@linux.vnet.ibm.com> <1433260778-26497-9-git-send-email-maddy@linux.vnet.ibm.com> <1433292866.438.64.camel@axtens.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1158440

Show key headers only | View raw


On Wednesday 03 June 2015 06:24 AM, Daniel Axtens wrote:
>> +int64_t opal_nest_ima_control(uint32_t value);
> If I'm understanding things correctly, you call this function in patch
> 3. Quoting from that patch:
>> +static void nest_init(void *dummy)
>> +{
>> +       opal_nest_ima_control(P8_NEST_ENGINE_START);
>> +}
> Does this patch need to be moved earlier in the series?
I applied all the patches together and tested it since the Makefile 
inclusion is
the final patch in the series. I guess it is better rearrange the series.

> Have you tested that the series compiles at every point?
> (I've found that this can be done quite easily with
>   git rebase --interactive using x to run the compile)
Nice. will try this out.

Thanks for the review
Maddy

>> +
>>   /* Internal functions */
>>   extern int early_init_dt_scan_opal(unsigned long node, const char *uname,
>>   				   int depth, void *data);
>> diff --git a/arch/powerpc/platforms/powernv/opal-wrappers.S b/arch/powerpc/platforms/powernv/opal-wrappers.S
>> index a7ade94..ce36a68 100644
>> --- a/arch/powerpc/platforms/powernv/opal-wrappers.S
>> +++ b/arch/powerpc/platforms/powernv/opal-wrappers.S
>> @@ -295,3 +295,4 @@ OPAL_CALL(opal_i2c_request,			OPAL_I2C_REQUEST);
>>   OPAL_CALL(opal_flash_read,			OPAL_FLASH_READ);
>>   OPAL_CALL(opal_flash_write,			OPAL_FLASH_WRITE);
>>   OPAL_CALL(opal_flash_erase,			OPAL_FLASH_ERASE);
>> +OPAL_CALL(opal_nest_ima_control,		OPAL_NEST_IMA_CONTROL);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU Daniel Axtens <dja@axtens.net> - 2015-06-03 03:00 +0200
  Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-06-04 12:30 +0200

csiph-web