Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU

From	Daniel Axtens <dja@axtens.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU
Date	2015-06-03 03:00 +0200
Message-ID	<px5cd-1n6-1@gated-at.bofh.it> (permalink)
References	<pwWVk-6d0-7@gated-at.bofh.it> <pwWVl-6d0-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> +int64_t opal_nest_ima_control(uint32_t value);

If I'm understanding things correctly, you call this function in patch
3. Quoting from that patch:
> +static void nest_init(void *dummy)
> +{
> +       opal_nest_ima_control(P8_NEST_ENGINE_START);
> +}
Does this patch need to be moved earlier in the series? 

Have you tested that the series compiles at every point? 
(I've found that this can be done quite easily with
 git rebase --interactive using x to run the compile)

> +
>  /* Internal functions */
>  extern int early_init_dt_scan_opal(unsigned long node, const char *uname,
>  				   int depth, void *data);
> diff --git a/arch/powerpc/platforms/powernv/opal-wrappers.S b/arch/powerpc/platforms/powernv/opal-wrappers.S
> index a7ade94..ce36a68 100644
> --- a/arch/powerpc/platforms/powernv/opal-wrappers.S
> +++ b/arch/powerpc/platforms/powernv/opal-wrappers.S
> @@ -295,3 +295,4 @@ OPAL_CALL(opal_i2c_request,			OPAL_I2C_REQUEST);
>  OPAL_CALL(opal_flash_read,			OPAL_FLASH_READ);
>  OPAL_CALL(opal_flash_write,			OPAL_FLASH_WRITE);
>  OPAL_CALL(opal_flash_erase,			OPAL_FLASH_ERASE);
> +OPAL_CALL(opal_nest_ima_control,		OPAL_NEST_IMA_CONTROL);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU Daniel Axtens <dja@axtens.net> - 2015-06-03 03:00 +0200
  Re: [PATCH v1 8/9] powerpc/powernv: Add OPAL support for Nest PMU Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-06-04 12:30 +0200

csiph-web