Re: [PATCH RFC] x86, tsc: Allow for high latency in quick_pit_calibrate()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] x86, tsc: Allow for high latency in quick_pit_calibrate()
Date	Wed, 03 Jun 2015 03:00:02 +0200
Message-ID	<px5ce-1n6-3@gated-at.bofh.it> (permalink)
References	<pstyy-8hF-7@gated-at.bofh.it> <px0cy-2yl-13@gated-at.bofh.it> <px0md-2Kn-13@gated-at.bofh.it> <px0md-2Kn-11@gated-at.bofh.it> <px0vV-2W2-13@gated-at.bofh.it> <px0FA-3mU-9@gated-at.bofh.it> <px0YX-3Kj-31@gated-at.bofh.it> <px1BD-4JV-1@gated-at.bofh.it> <px3WN-856-1@gated-at.bofh.it> <px4Jb-OH-9@gated-at.bofh.it> <px52y-1bs-15@gated-at.bofh.it>
X-Original-To	Andi Kleen <ak@linux.intel.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=ClVkWadMK96Nvx00m/20UhFYR78864r8huHwb/ghKYo=; b=Ay0r4nU2yHEUCeQbqKdgJ62FNnkA0OovWD/xnj5SoEzytkxxs4Date/E0K/NqpY6Kg 9hYGuGLNJJE4TzLoMEcc7lYkDXnYX4EinLZZBGizJG1tiZyBQqtdtfKBqQVTnQJl81a+ +YQhbbcJhaaT1hNOFYKKmOKfEUye5rWF3c9XV8G2PHsaIM4D4nbfdmQUgDk84GSD+M+0 WKbOlD/xJlAjJ9mi/sVUOKV4kyab+uIh55TJoFfEQQozCfHOluH5HJUjUzZWEsTlka27 AFhWwC1f1hxxaTSxqv9ifOK5majIiM3boWEtRasf4xhkT/wB4PNZQd6LsgboM37Rix6a Ja5A==
X-Gm-Message-State	ALoCoQk4eCBciREYgQ8pEfkdLpqwKlu6/3AXifoBkmZfpMA8XjLs1haHgmUDWAw4hVBE2Z+l300y
X-Received	by 10.152.121.42 with SMTP id lh10mr29716108lab.0.1433293125861; Tue, 02 Jun 2015 17:58:45 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, Adrian Hunter <adrian.hunter@intel.com>, LKML <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>
X-Original-Date	Tue, 2 Jun 2015 17:58:25 -0700
X-Original-Message-ID	<CALCETrUOpU8QT6zG4QUtD8sfBZMDEMbNstz0f0EiW99=vrFOYQ@mail.gmail.com>
X-Original-References	<1432194944-29087-1-git-send-email-adrian.hunter@intel.com> <alpine.DEB.2.11.1506022130330.20347@nanos> <CALCETrV2AMXZON5N0cvXeP=KAL-q-tDeuAGD10DtR4miLteE8w@mail.gmail.com> <20150602194350.GN1187@tassilo.jf.intel.com> <alpine.DEB.2.11.1506022148220.20347@nanos> <CALCETrVQX8Z-oEhNZvgkGOSZskyxoPmG3Mdz+xcZTeVRHhZtyA@mail.gmail.com> <20150602202037.GO1187@tassilo.jf.intel.com> <alpine.DEB.2.11.1506022302340.20347@nanos> <20150602233820.GP1187@tassilo.jf.intel.com> <CALCETrXpjHcDhS47B+HQV_kUQVivwgsnFPNyx7kaskXpRjDgnw@mail.gmail.com> <20150603003938.GQ1187@tassilo.jf.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1157007

Show key headers only | View raw

On Tue, Jun 2, 2015 at 5:39 PM, Andi Kleen <ak@linux.intel.com> wrote:
> On Tue, Jun 02, 2015 at 05:21:27PM -0700, Andy Lutomirski wrote:
>> On Tue, Jun 2, 2015 at 4:38 PM, Andi Kleen <ak@linux.intel.com> wrote:
>> > On Tue, Jun 02, 2015 at 11:03:26PM +0200, Thomas Gleixner wrote:
>> >>
>> >>
>> >> On Tue, 2 Jun 2015, Andi Kleen wrote:
>> >>
>> >> > > There's the code in tsc_msr.c.  It should be relatively
>> >> > > straightforward to extend it to cover everything that intel_pstate
>> >> > > supports.
>> >> >
>> >> > That's a good idea, but we still need an always working fallback when the
>> >> > model number is not available. So Adrian's patch is needed in any
>> >> > case.
>> >>
>> >> Nonsense. The slow calibration is already a working fallback.
>> >
>> > Please read Adrian's description again. It's not working when the PIT read is
>> > too slow. That is when the new algorithm is needed.
>> >
>>
>> tglx's suggestion was to use slow calibration as a fallback.
>
> You mean the last fallback we have today?
>
> That one doesn't work if the PIT read is too slow.
>
> And Adrian's patch is fixing that.

Then the changelog should say that I think.  The current text says
"Fast TSC calibration will always fail", which, to me, suggests that
either the slow calibration will work or that the changelog message
should be changed.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH RFC] x86, tsc: Allow for high latency in  quick_pit_calibrate() Andi Kleen <ak@linux.intel.com> - 2015-06-03 01:40 +0200
  Re: [PATCH RFC] x86, tsc: Allow for high latency in quick_pit_calibrate() Andy Lutomirski <luto@amacapital.net> - 2015-06-03 02:30 +0200
    Re: [PATCH RFC] x86, tsc: Allow for high latency in  quick_pit_calibrate() Andi Kleen <ak@linux.intel.com> - 2015-06-03 02:50 +0200
      Re: [PATCH RFC] x86, tsc: Allow for high latency in quick_pit_calibrate() Andy Lutomirski <luto@amacapital.net> - 2015-06-03 03:00 +0200
        Re: [PATCH RFC] x86, tsc: Allow for high latency in  quick_pit_calibrate() Thomas Gleixner <tglx@linutronix.de> - 2015-06-03 18:30 +0200
        Re: [PATCH RFC] x86, tsc: Allow for high latency in quick_pit_calibrate() Adrian Hunter <adrian.hunter@intel.com> - 2015-06-04 13:40 +0200

csiph-web