Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1210565

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero
Date Thu, 20 Aug 2015 16:50:05 +0200
Message-ID <pZzkh-7Tp-87@gated-at.bofh.it> (permalink)
References <pZz0R-7wx-11@gated-at.bofh.it> <pZzkh-7Tp-89@gated-at.bofh.it>
X-Original-To Michal Suchanek <hramrach@gmail.com>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YnIutncTLXsDZs5t"
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 51
Organization linux.* mail to news gateway
X-Original-Cc linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@arm.linux.org.uk>, Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
X-Original-Date Thu, 20 Aug 2015 16:48:36 +0200
X-Original-Message-ID <20150820144836.GV30520@lukather>
X-Original-References <cover.1440080122.git.hramrach@gmail.com> <3688fab67e7cdc7bcbff73dfd6b0fcdcc4e79eb6.1440080122.git.hramrach@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1210565

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote:
> When the maximum transfer speed is not set for a SPI slave the value
> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary
> speed instead in that case.
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>

spi->max_speed_hz is set using the spi-max-frequency property, and
spi->will error out if that property isn't set. What am I missing?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 16:50 +0200
  Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Michal Suchanek <hramrach@gmail.com> - 2015-08-20 21:50 +0200
    Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 23:30 +0200

csiph-web