Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero
Date	2015-08-20 23:30 +0200
Message-ID	<pZFzk-7l-23@gated-at.bofh.it> (permalink)
References	<pZz0R-7wx-11@gated-at.bofh.it> <pZzkh-7Tp-89@gated-at.bofh.it> <pZzkh-7Tp-87@gated-at.bofh.it> <pZE0y-6as-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 20, 2015 at 09:45:07PM +0200, Michal Suchanek wrote:
> On 20 August 2015 at 16:48, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Thu, Aug 20, 2015 at 02:19:46PM -0000, Michal Suchanek wrote:
> >> When the maximum transfer speed is not set for a SPI slave the value
> >> remains 0 and the code in sunxi SPI divides by it. Use an arbitrary
> >> speed instead in that case.
> >>
> >> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> >
> > spi->max_speed_hz is set using the spi-max-frequency property, and
> > spi->will error out if that property isn't set. What am I missing?
> >
> 
> Spidev I guess.
> 
> You can set the speed to arbitrary value from userspace at any time
> using the spidev ioctls.

Then why should it be fixed at the controller driver level? It looks
more like an issue that impacts everyone and should be fixed either in
spidev directly or in the framework.

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 16:50 +0200
  Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Michal Suchanek <hramrach@gmail.com> - 2015-08-20 21:50 +0200
    Re: [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 23:30 +0200

csiph-web