Re: [PATCH] powerpc/hvsi: Fix endianness issues in the HVSI driver

From	Laurent Dufour <ldufour@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powerpc/hvsi: Fix endianness issues in the HVSI driver
Date	2015-08-19 23:40 +0200
Message-ID	<pZjfs-1gK-3@gated-at.bofh.it> (permalink)
References	<pSeXf-1yJ-1@gated-at.bofh.it> <pTlMZ-1eF-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/08/2015 13:00, David Laight wrote:
> From: Laurent Dufour
>> Sent: 31 July 2015 10:30
>> This patch fixes several endianness issues detected when running the HVSI
>> driver in little endian mode.
>>
>> These issues are raised in little endian mode because the data exchanged in
>> memory between the kernel and the hypervisor has to be in big endian
>> format.
> ...
>> diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
>> index 41901997c0d6..a75146f600cb 100644
>> --- a/drivers/tty/hvc/hvsi.c
>> +++ b/drivers/tty/hvc/hvsi.c
>> @@ -240,9 +240,9 @@ static void hvsi_recv_control(struct hvsi_struct *hp, uint8_t *packet,
>>  {
>>  	struct hvsi_control *header = (struct hvsi_control *)packet;
>>
>> -	switch (header->verb) {
>> +	switch (be16_to_cpu(header->verb)) {
>>  		case VSV_MODEM_CTL_UPDATE:
>> -			if ((header->word & HVSI_TSCD) == 0) {
>> +			if ((be32_to_cpu(header->word) & HVSI_TSCD) == 0) {
> 
> It is generally best to byteswap constants.
> 
> 	David

Thanks David for your review.
Regarding the byte swapping of the constants, I'm wondering if this  the
best way here.
For instance, Benjamin wrote a similar patch to fix another endianness
issue (99fc1d91b8fc) and he doesn't convert the constant neither.
It think that byte swapping the constant value will impact more code,
and may not ease code reading.

Cheers,
Laurent.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] powerpc/hvsi: Fix endianness issues in the HVSI driver Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2015-08-19 23:40 +0200
  Re: [PATCH] powerpc/hvsi: Fix endianness issues in the HVSI driver Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2015-08-20 00:00 +0200

csiph-web