Re: [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency
Date	2015-08-19 23:30 +0200
Message-ID	<pZj5P-15x-59@gated-at.bofh.it> (permalink)
References	<pZ9J7-4sk-3@gated-at.bofh.it> <pZ9J9-4sk-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 19, 2015 at 01:19:58PM +0200, Javier Martinez Canillas wrote:
> The ChromeOS EC keyboard driver config depend on CROS_EC_PROTO but
> MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
> on is bad practice as it may lead to circular Kconfig dependencies.
> 
> Since the platform device that is matched with the keyboard driver
> is registered by the ChromeOS EC mfd driver, KEYBOARD_CROS_EC really
> should depend on MFD_CROS_EC. And because this config option selects
> CROS_EC_PROTO, that dependency is met as well. So make the driver
> to depend on MFD_CROS_EC instead of CROS_EC_PROTO.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied, thank you.

> 
> 
> ---
> 
>  drivers/input/keyboard/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index da53ae6a9334..2e80107ff630 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -689,7 +689,7 @@ config KEYBOARD_W90P910
>  config KEYBOARD_CROS_EC
>  	tristate "ChromeOS EC keyboard"
>  	select INPUT_MATRIXKMAP
> -	depends on CROS_EC_PROTO
> +	depends on MFD_CROS_EC
>  	help
>  	  Say Y here to enable the matrix keyboard used by ChromeOS devices
>  	  and implemented on the ChromeOS EC. You must enable one bus option
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] ChromeOS EC Kconfig cleanups Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200
  [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200
    Re: [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead  CROS_EC_PROTO Olof Johansson <olof@lixom.net> - 2015-08-21 19:20 +0200
  [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200
    Re: [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-19 23:30 +0200

csiph-web