Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209761

Re: [PATCH 1/9] staging: most: NULL comparison style

Show all headers | View raw

On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote:
> On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > According to the kernel coding style the NULL check should not be
> > written as [variable] == NULL or [variable] != NULL.
> 
> It seems this not documented in Documentation/CodingStyle .
Yes, it is not in the CodingStyle file. But mostly it is the convention
that is followed. And in CodingStyle file if you see the "The rationale
for using gotos is:" section, you will see in the example function the
test is done like: if (!buffer).
Anyways, frankly speaking I know commit message is bad but I could not
think of anything else other than the one I wrote. Any ideas please...

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 4/9] staging: most: out of memory error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 8/9] staging: most: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 9/9] staging: most: fix Makefile Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 6/9] staging: most: make functions static Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 5/9] staging: most: remove unused functions Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 7/9] staging: most: use NULL pointer Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 3/9] staging: most: remove multiple blank line Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 2/9] staging: most: bool comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:30 +0200
  Re: [PATCH 1/9] staging: most: NULL comparison style Fabio Estevam <festevam@gmail.com> - 2015-08-18 18:40 +0200
    Re: [PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-19 12:10 +0200
      Re: [PATCH 1/9] staging: most: NULL comparison style Frans Klaver <fransklaver@gmail.com> - 2015-08-19 17:00 +0200
  [PATCH v2] staging: most: NULL comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-24 15:50 +0200

csiph-web