Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209310

[PATCH 2/9] staging: most: bool comparison style

Show all headers | View raw

Mentioning true or false in the if comparison is error prone and also
not according to the coding style.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/staging/most/aim-cdev/cdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
index 7b637f3..e5853d0 100644
--- a/drivers/staging/most/aim-cdev/cdev.c
+++ b/drivers/staging/most/aim-cdev/cdev.c
@@ -133,7 +133,7 @@ static int aim_close(struct inode *inode, struct file *filp)
 
 	while (0 != kfifo_out((struct kfifo *)&channel->fifo, &mbo, 1))
 		most_put_mbo(mbo);
-	if (channel->keep_mbo == true)
+	if (channel->keep_mbo)
 		most_put_mbo(channel->stacked_mbo);
 	ret = most_stop_channel(channel->iface, channel->channel_id);
 	atomic_dec(&channel->access_ref);
@@ -224,7 +224,7 @@ aim_read(struct file *filp, char __user *buf, size_t count, loff_t *offset)
 	struct mbo *mbo;
 	struct aim_channel *channel = filp->private_data;
 
-	if (channel->keep_mbo == true) {
+	if (channel->keep_mbo) {
 		mbo = channel->stacked_mbo;
 		channel->keep_mbo = false;
 		goto start_copy;
@@ -259,7 +259,7 @@ start_copy:
 
 	retval = not_copied ? proc_len - not_copied : proc_len;
 
-	if (channel->keep_mbo == true) {
+	if (channel->keep_mbo) {
 		channel->mbo_offs = retval;
 		channel->stacked_mbo = mbo;
 	} else {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 4/9] staging: most: out of memory error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 8/9] staging: most: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 9/9] staging: most: fix Makefile Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 6/9] staging: most: make functions static Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 5/9] staging: most: remove unused functions Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 7/9] staging: most: use NULL pointer Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 3/9] staging: most: remove multiple blank line Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:20 +0200
  [PATCH 2/9] staging: most: bool comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 17:30 +0200
  Re: [PATCH 1/9] staging: most: NULL comparison style Fabio Estevam <festevam@gmail.com> - 2015-08-18 18:40 +0200
    Re: [PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-19 12:10 +0200
      Re: [PATCH 1/9] staging: most: NULL comparison style Frans Klaver <fransklaver@gmail.com> - 2015-08-19 17:00 +0200

csiph-web