Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208845

Re: [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk

Show all headers | View raw

On Mon, Aug 17, 2015 at 03:28:27PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c  |  4 ++--
>  drivers/staging/wilc1000/linux_wlan.c        |  8 ++++----
>  drivers/staging/wilc1000/linux_wlan_common.h | 28 ++++++++++++++--------------
>  drivers/staging/wilc1000/linux_wlan_sdio.c   |  2 +-
>  drivers/staging/wilc1000/linux_wlan_spi.c    |  2 +-
>  drivers/staging/wilc1000/wilc_debugfs.c      | 16 ++++++++--------
>  drivers/staging/wilc1000/wilc_exported_buf.c |  2 --
>  7 files changed, 30 insertions(+), 32 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 1a5b165..8a0ebba 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -2005,7 +2005,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
>  							pstrWIDs[counter].u16WIDid,
>  							(counter == u32WIDsCount - 1), drvHandler)) {
>  				ret = -1;
> -				printk("[Sendconfigpkt]Get Timed out\n");
> +				pr_err("[Sendconfigpkt]Get Timed out\n");

This is a network driver, please use the proper logging statement for
such a thing (i.e. netdev_err()).

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-17 21:30 +0200
  Re: [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-17 22:00 +0200
    [PATCHv3] staging: wilc1000: use netdev_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-18 01:10 +0200
      Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 06:30 +0200
        Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-18 07:30 +0200
          Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 08:20 +0200
      Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-19 05:00 +0200

csiph-web