Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1209041

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

From Raphaël Beamonte <raphael.beamonte@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk
Date 2015-08-18 07:30 +0200
Message-ID <pYHDc-54g-1@gated-at.bofh.it> (permalink)
References <pYyJz-lu-3@gated-at.bofh.it> <pYBHr-4Ns-5@gated-at.bofh.it> <pYGH7-3Jf-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2015-08-18 0:24 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> +                             netdev_err("[Sendconfigpkt]Get Timed out\n");
> This will not compile. you can not just replace printk with
> netdev_*, you need to mention a net_device.

You're right! I'm making a lot of mistakes. It seems I called the make
command in the wrong git tree... Thanks for catching that, and taking
time to review!
I just saw there isn't any netdev_debug available. Do you know the
reason for that? Is there a replacement besides pr_debug?
Also, it seems that in all the functions where it's another netdev
that's available that I could use, I don't have access to the
net_device struct. Is there a general way to get that device
information? I saw an old lkml post talking about dev_*() functions to
do that? Would you have some hint on the matter?

Thanks a lot!
Raphaël
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-17 21:30 +0200
  Re: [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-17 22:00 +0200
    [PATCHv3] staging: wilc1000: use netdev_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-18 01:10 +0200
      Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 06:30 +0200
        Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-08-18 07:30 +0200
          Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-18 08:20 +0200
      Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-19 05:00 +0200

csiph-web