Groups > linux.kernel > #1209205

Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mathias Nyman <mathias.nyman@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start
Date	Tue, 18 Aug 2015 13:40:02 +0200
Message-ID	<pYNpg-4Ug-29@gated-at.bofh.it> (permalink)
References	<pYMtc-3yQ-9@gated-at.bofh.it> <pYMtc-3yQ-15@gated-at.bofh.it>
X-Original-To	Roger Quadros <rogerq@ti.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.15,701,1432623600"; d="scan'208";a="770961265"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 18 Aug 2015 14:43:00 +0300
X-Original-Message-ID	<55D31A44.6050107@intel.com>
X-Original-References	<1439894354-6160-1-git-send-email-rogerq@ti.com> <1439894354-6160-4-git-send-email-rogerq@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1209205

Show key headers only | View raw

On 18.08.2015 13:39, Roger Quadros wrote:
> For whatever reason if XHCI died in the previous instant
> then it will never recover on the next xhci_start unless we
> clear the DYING flag.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>   drivers/usb/host/xhci.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index f998ddf..d5f44b1 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -146,7 +146,8 @@ static int xhci_start(struct xhci_hcd *xhci)
>   				"waited %u microseconds.\n",
>   				XHCI_MAX_HALT_USEC);
>   	if (!ret)
> -		xhci->xhc_state &= ~XHCI_STATE_HALTED;
> +		xhci->xhc_state &= ~(XHCI_STATE_HALTED | XHCI_STATE_DYING);
> +
>   	return ret;
>   }
>
>

Thanks, applied

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start Roger Quadros <rogerq@ti.com> - 2015-08-18 12:40 +0200
  Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start Mathias Nyman <mathias.nyman@intel.com> - 2015-08-18 13:40 +0200

csiph-web