Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1209171 > unrolled thread
| Started by | Roger Quadros <rogerq@ti.com> |
|---|---|
| First post | 2015-08-18 12:40 +0200 |
| Last post | 2015-08-18 13:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start Roger Quadros <rogerq@ti.com> - 2015-08-18 12:40 +0200
Re: [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start Mathias Nyman <mathias.nyman@intel.com> - 2015-08-18 13:40 +0200
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2015-08-18 12:40 +0200 |
| Subject | [PATCH 3/5] usb: xhci: Clear XHCI_STATE_DYING on start |
| Message-ID | <pYMtc-3yQ-15@gated-at.bofh.it> |
For whatever reason if XHCI died in the previous instant then it will never recover on the next xhci_start unless we clear the DYING flag. Signed-off-by: Roger Quadros <rogerq@ti.com> --- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index f998ddf..d5f44b1 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -146,7 +146,8 @@ static int xhci_start(struct xhci_hcd *xhci) "waited %u microseconds.\n", XHCI_MAX_HALT_USEC); if (!ret) - xhci->xhc_state &= ~XHCI_STATE_HALTED; + xhci->xhc_state &= ~(XHCI_STATE_HALTED | XHCI_STATE_DYING); + return ret; } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Mathias Nyman <mathias.nyman@intel.com> |
|---|---|
| Date | 2015-08-18 13:40 +0200 |
| Message-ID | <pYNpg-4Ug-29@gated-at.bofh.it> |
| In reply to | #1209171 |
On 18.08.2015 13:39, Roger Quadros wrote: > For whatever reason if XHCI died in the previous instant > then it will never recover on the next xhci_start unless we > clear the DYING flag. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > drivers/usb/host/xhci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index f998ddf..d5f44b1 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -146,7 +146,8 @@ static int xhci_start(struct xhci_hcd *xhci) > "waited %u microseconds.\n", > XHCI_MAX_HALT_USEC); > if (!ret) > - xhci->xhc_state &= ~XHCI_STATE_HALTED; > + xhci->xhc_state &= ~(XHCI_STATE_HALTED | XHCI_STATE_DYING); > + > return ret; > } > > Thanks, applied -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web