Groups > linux.kernel > #1208924

Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps()

From	Bjorn Helgaas <bhelgaas@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps()
Date	2015-08-18 00:40 +0200
Message-ID	<pYBep-407-3@gated-at.bofh.it> (permalink)
References	<pRHRD-4o7-9@gated-at.bofh.it> <pRHRE-4o7-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 29, 2015 at 04:18:55PM -0600, Keith Busch wrote:
> From: Dave Jiang <dave.jiang@intel.com>
> 
> The setting of PCIe MPS should be left to the PCI subsystem and not
> the driver. An ill configured MPS by the driver could cause the device
> to not function or unstablize the entire system. Removing the exported
> symbol.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/pci/pci.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 0008c95..92349ee 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4121,7 +4121,6 @@ int pcie_set_mps(struct pci_dev *dev, int mps)
>  	return pcie_capability_clear_and_set_word(dev, PCI_EXP_DEVCTL,
>  						  PCI_EXP_DEVCTL_PAYLOAD, v);
>  }
> -EXPORT_SYMBOL(pcie_set_mps);

I think the pcie_set_mps() declaration could be moved from
include/linux/pci.h to drivers/pci/pci.h, couldn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps() Bjorn Helgaas <bhelgaas@google.com> - 2015-08-18 00:40 +0200
  Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps() "Jiang, Dave" <dave.jiang@intel.com> - 2015-08-18 01:40 +0200

csiph-web