Groups > linux.kernel > #1207982

Re: [PATCH] regmap: Add function check before called format_val

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regmap: Add function check before called format_val
Date	2015-08-15 04:20 +0200
Message-ID	<pXzeF-3OQ-11@gated-at.bofh.it> (permalink)
References	<pOiG6-1tv-17@gated-at.bofh.it> <pOkRA-4NY-17@gated-at.bofh.it> <pOyUx-8gm-11@gated-at.bofh.it> <pWFcu-70d-11@gated-at.bofh.it> <pX2C6-7ft-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 13, 2015 at 11:25:05PM +0800, Henry Chen wrote:
> On Wed, 2015-08-12 at 22:20 +0800, Daniel Kurtz wrote:

> > Making mtk_pmic-wrap into a regmap_bus makes a bit of sense
> > architecturally, too, since it is essentially just a bus for accessing
> > the registers of an off-chip PMIC.  The CPU sees a platform bus, but
> > the registers of the remote PMIC are accessed over a dedicated SPI
> > bus.

> Sorry, I'm afraid that I cannot do this right on init as you said last
> time. What do you think about regmap_bus, can you accept that way?

I don't have enough context from the above to understand what's going
on, sorry.  Implementing a bus for something that isn't actually a Linux
bus doesn't seem like the best idea though and in general what I'm
seeing of the discussion sounds like you're hacking around in driver
code to bodge around problems that are being seen rather than really
addressing things, the code I can see certainly looks like it just wants
to be implementing read and write operations for a single MFD.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] regmap: Add function check before called format_val Daniel Kurtz <djkurtz@chromium.org> - 2015-08-12 16:30 +0200
  Re: [PATCH] regmap: Add function check before called format_val Henry Chen <HenryC.Chen@mediatek.com> - 2015-08-13 17:30 +0200
    Re: [PATCH] regmap: Add function check before called format_val Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200

csiph-web