Groups > linux.kernel > #1207951

Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular
Date	2015-08-15 02:20 +0200
Message-ID	<pXxmx-13c-1@gated-at.bofh.it> (permalink)
References	<pVn7Y-6Vo-3@gated-at.bofh.it> <pVn7Y-6Vo-7@gated-at.bofh.it> <pW0j0-6f6-11@gated-at.bofh.it> <pWaV4-4VF-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 11, 2015 at 02:05:44AM -0400, Paul Gortmaker wrote:
> [Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular] On 10/08/2015 (Mon 20:42) Joachim Eastwood wrote:
> 
> > Hi Paul,
> > 
> > On 9 August 2015 at 02:51, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> > > The Kconfig currently controlling compilation of this code is:
> > >
> > > 8250/Kconfig:config SERIAL_8250_LPC18XX
> > > 8250/Kconfig:        bool "NXP LPC18xx/43xx serial port support"
> > >
> > > ...meaning that it currently is not being built as a module by anyone.
> > >
> > > Lets remove the modular code that is essentially orphaned, so that
> > > when reading the driver there is no doubt it is builtin-only.
> > 
> > The bool in KConfig is more or less a copy-paste mistake on my side. I
> > really meant for this driver to be buildable as module and it builds
> > just fine with 'm'.
> > 
> > Want me send a patch changing it to tristate or will you handle it?
> 
> I will do a v2 in the next day or so with collected ACKs and this patch
> replaced, unless Greg jumps in and indicates he'd like something
> different.

Nope, that would be fine with me, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
  [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
    Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular Joachim Eastwood <manabian@gmail.com> - 2015-08-10 20:50 +0200
      Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-11 08:10 +0200
        Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly  non-modular Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 02:20 +0200
  [PATCH 3/5] drivers/tty: make hvc_console.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
    Re: [3/5] drivers/tty: make hvc_console.c explicitly non-modular Michael Ellerman <mpe@ellerman.id.au> - 2015-08-10 08:40 +0200
  [PATCH 2/5] drivers/tty: make sysrq.c slightly more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200

csiph-web