Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1203839

Re: [3/5] drivers/tty: make hvc_console.c explicitly non-modular

Show all headers | View raw

On Sun, 2015-09-08 at 00:51:35 UTC, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/tty/hvc/Kconfig:config HVC_DRIVER
> drivers/tty/hvc/Kconfig:        bool
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only, even
> though someone bothered to comment that the code was not used.
> 
> Unlike other changes, this driver binds in w/o using module_init,
> so we dont have init ordering concerns with this commit.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Seems sane to me, possibly back in the deep dark past it could be a module, but
no point keeping the code around if it can't anymore.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
  [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
    Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular Joachim Eastwood <manabian@gmail.com> - 2015-08-10 20:50 +0200
      Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-11 08:10 +0200
        Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly  non-modular Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 02:20 +0200
  [PATCH 3/5] drivers/tty: make hvc_console.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200
    Re: [3/5] drivers/tty: make hvc_console.c explicitly non-modular Michael Ellerman <mpe@ellerman.id.au> - 2015-08-10 08:40 +0200
  [PATCH 2/5] drivers/tty: make sysrq.c slightly more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-09 03:00 +0200

csiph-web