Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1207938

RE: [Intel-wired-lan] [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

Show all headers | View raw

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Jia-Ju Bai
> Sent: Wednesday, August 05, 2015 3:16 AM
> To: Kirsher, Jeffrey T; Brandeburg, Jesse
> Cc: netdev@vger.kernel.org; Jia-Ju Bai; intel-wired-lan@lists.osuosl.org;
> linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v2] e1000e: Modify tx/rx configurations
> to avoid null pointer dereferences in e1000_open
> 
> When e1000e_setup_rx_resources is failed in e1000_open,
> e1000e_free_tx_resources in "err_setup_rx" segment is executed.
> "writel(0, tx_ring->head)" statement in e1000_clean_tx_ring
> in e1000e_free_tx_resources will cause a null poonter dereference(crash),
> because "tx_ring->head" is only assigned in e1000_configure_tx
> in e1000_configure, but it is after e1000e_setup_rx_resources.
> 
> This patch moves head/tail register writing to e1000_configure_tx/rx,
> which can fix this problem. It is inspired by igb_configure_tx_ring
> in the igb driver.
> 
> Specially, thank Alexander Duyck for his valuable suggestion.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c |   24 ++++++++++++-----------
> -
>  1 file changed, 12 insertions(+), 12 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown@intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open Jia-Ju Bai <baijiaju1990@163.com> - 2015-08-05 12:20 +0200
  Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null  pointer dereferences in e1000_open Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-08-05 12:50 +0200
    Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null  pointer dereferences in e1000_open Jia-Ju Bai <baijiaju1990@163.com> - 2015-08-05 14:40 +0200
  RE: [Intel-wired-lan] [PATCH v2] e1000e: Modify tx/rx  configurations to avoid null pointer dereferences in e1000_open "Brown, Aaron F" <aaron.f.brown@intel.com> - 2015-08-15 01:30 +0200

csiph-web